Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 200555

Summary:	Review Request: libsynaptics - Synaptics touchpad driver library
Product:	[Fedora] Fedora	Reporter:	Orion Poplawski <orion>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://www.cora.nwra.com/~orion/fedora/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-07-31 16:25:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 200565

Description Orion Poplawski 2006-07-28 16:58:33 UTC

Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/libsynaptics.spec
SRPM Name or Url:
http://www.cora.nwra.com/~orion/fedora/libsynaptics-0.14.6b-1.fc5.src.rpm
Description: 

A small C++ library usable by the synaptics driver.
The version numbering will follow any driver releases, the appended letter
marks releases due to bug fixing.


This is needed by ksynaptics

Comment 1 Rex Dieter 2006-07-28 18:21:05 UTC

Guess I need to review this one too... (:

Comment 2 Rex Dieter 2006-07-28 18:26:22 UTC

First, Version should not contain non-numerics, (see
http://www.fedoraproject.org/wiki/Packaging/NamingGuide)

You should use (something like):
Version: 0.14.6
Release: 1.b%{?dist}

The easiest way to deal with this is to use some macro, say %beta
%define beta b
Then use:
Release: 1.%{beta}


Because of the munging of Version, you'll need to modify other bits to be 
(again, something like):
Source0:        
http://qsynaptics.sourceforge.net/libsynaptics-%{version}%{?beta}.tar.bz2
...
%setup -q -n %{name}-%{version}%{?beta}

Comment 3 Rex Dieter 2006-07-28 18:48:26 UTC

upstream source checks:
6ea2b72829df76138a9a1f03faeda438  libsynaptics-0.14.6b.tar.bz2

This one is pretty simple and straightforward.  Make the recommended 
Version/Release modification, and I'll approve this.

Comment 4 Thorsten Leemhuis 2006-07-28 19:55:38 UTC

Just FYI (don't know if relevant to this package or ksynaptics): devel-PPC
currently is missing synaptics; see Bug 199864 for details

Comment 5 Orion Poplawski 2006-07-28 20:13:56 UTC

This is a post-release non-numeric version.  It will be followed by 0.14.6c or
0.14.7, so, according to the guidelines:

Post-release packages: Packages released after a "final" version. This usually
is due to a quick bugfix release, such as openssl-0.9.6b  or gkrellm-2.1.7a. In
this case, the non-numeric characters are permitted in the Version: field.

See http://qsynaptics.sourceforge.net/dl.html for historical version numbers.

Thanks for the heads up on PPC.  I'll do an ExcludeArch if needed.  If I can
avoid it I will, though we might end up with a package for ppc that just won't work.

Comment 6 Rex Dieter 2006-07-28 22:28:03 UTC

>Post-release packages: Packages released after a "final" version

Well, I'll be, didn't know about that exception, ya learn something new every day.

Looks good then, approved.

Comment 7 Orion Poplawski 2006-07-31 16:25:30 UTC

Imported, built on devel, and added to owners.list.