Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 200565
Summary: | Review Request: ksynaptics - KDE configuration for synaptics module | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.cora.nwra.com/~orion/fedora/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-31 16:25:54 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 200555 | ||
Bug Blocks: | 163779 |
Description
Orion Poplawski
2006-07-28 17:51:46 UTC
upstream source checks out. c9c124ba59bbb898bfc73f2ab00e8006 ksynaptics-0.3.1.tar.bz2 A few initial comments: 1. Icons need scriptlets (See http://www.fedoraproject.org/wiki/ScriptletSnippets), something like: %post touch --no-create %{_datadir}/icons/hicolor || : gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||: %postun 2. You don't really need: export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include anymore, the qt bug that this worked around is now fixed. touch --no-create %{_datadir}/icons/hicolor || : gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||: Otherwise it looks good! Now, I'll try building and see how it works... (: oops, left %postun blank, it should have been the same: %post touch --no-create %{_datadir}/icons/hicolor || : gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||: I'd suggest replacing: desktop-file-install --vendor=fedora \ --add-category=Qt \ --add-category=KDE \ --add-category=Utility \ --add-category=X-Fedora \ --delete-original --dir %{buildroot}%{_datadir}/applications \ $RPM_BUILD_ROOT/%{_datadir}/applications/kde/%{name}.desktop with simply: desktop-file-install \ --vendor="" --add-category=X-Fedora \ --dir $RPM_BUILD_ROOT%{_datadir}/applications/kde \ $RPM_BUILD_ROOT%{_datadir}/applications/kde/*.desktop The vendor is clear already here (kde), and this is simply a KControl module, so there's no need to add those Categories. spec and src.rpm updated. New srpm: http://www.cora.nwra.com/~orion/fedora/ksynaptics-0.3.1-1.fc5.src.rpm though you really only need the new spe. - Add icon post/postun scripts - Add Requires: hicolor-icon-theme - Remove old QTDIR hack - Cleanup desktop file Not sure if the hicolor-icon-theme requires is necessary, but I would think so since it installs into %{_datadir}/icons/hicolor/... Thanks for the reviews Rex! The Requires: hicolo-icon-theme probably isn't absolutely required, but I guess it doesn't hurt either. approved. Imported, built on devel, and added to owners.list. |