Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 201480
| Summary: | Review Request: perl-DateTime-Format-Builder | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Patrice Dumas <pertusus> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | pertusus |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/DateTime-Format-Builder | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-08-08 22:07:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 201476, 201477, 201478, 201479 | ||
| Bug Blocks: | 163779, 201481 | ||
|
Description
Chris Weyl
2006-08-06 00:15:54 UTC
For tests, missing BR: perl(Test::Pod) perl(Test::More) maybe perl(DTFB::OnFailTest) perl(DTFB::Quick) maybe Params::Validate => 0.72 since it is in Build.PL, but is it required for build? I guess so for tests? README and LICENCE missing from %doc BR's and %doc updated; perl(DTFB::*) are actually packages defined in and as part of the test suites, so they were not included. SRPM URL: http://home.comcast.net/~ckweyl/perl-DateTime-Format-Builder-0.7807-2.fc5.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-DateTime-Format-Builder.spec * rpmlint is silent * package named according to guidelines * free software, licences included * meets packaging guidelines * spec legible * source match upstream 4f6ee670cab944db0492e70ca8df3be3 ./DateTime-Format-Builder-0.7807.tar.gz * sane provides Provides: perl(DateTime::Format::Builder) = 0.7807 perl(DateTime::Format::Builder::Parser) = 0.77 perl(DateTime::Format::Builder::Parser::Dispatch) = 0.78 perl(DateTime::Format::Builder::Parser::Quick) = 0.77 perl(DateTime::Format::Builder::Parser::Regex) = 0.77 perl(DateTime::Format::Builder::Parser::Strptime) = 0.77 perl(DateTime::Format::Builder::Parser::generic) = 0.77 * %files section right APPROVED You could add a comment to
mv LICENCE LICENSE
And
perl -pi -e 's/E<copy>/(C)/' `find lib/ -type f`
could be more classically something along
find lib/ -type f -exec sed -i -e 's/E<copy>/(C)/' {} \;
but it is a perl module, so there is more than one way
to do it ;-)
+Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching +Close bug Thanks for the review! (In reply to comment #4) > perl -pi -e 's/E<copy>/(C)/' `find lib/ -type f` > could be more classically something along > find lib/ -type f -exec sed -i -e 's/E<copy>/(C)/' {} \; > but it is a perl module, so there is more than one way > to do it ;-) TMTOWTDI, even outside perl :) |