Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 201476 - Review Request: perl-DateTime-Format-HTTP
Summary: Review Request: perl-DateTime-Format-HTTP
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Package Reviews List
URL: http://search.cpan.org/dist/DateTime-...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 201480
TreeView+ depends on / blocked
 
Reported: 2006-08-05 23:58 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-07 01:25:46 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Chris Weyl 2006-08-05 23:58:32 UTC
SRPM URL: http://home.comcast.net/~ckweyl/perl-DateTime-Format-HTTP-0.36-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-DateTime-Format-HTTP.spec

Description:
This module provides functions that deal with the date formats used by the
HTTP protocol (and then some).

Comment 1 Patrice Dumas 2006-08-06 12:55:38 UTC
Blocker:
- For t/pod99.t missing BuildRequires: perl(File::Find::Rule)

Remarks:
- the Summary could be more precise, like
HTTP protocol date conversion routines

- no need to 
  mv LICENCE LICENSE
  it is the spec file that must be american english

Otherwise
* rpmlint is silent
* free software, licences included
* meets packaging guidelines
* spec legible
* match upstream
8f40176f012e293743ffbdb42791e40c  ./DateTime-Format-HTTP-0.36.tar.gz
* sane provides:
Provides: perl(DateTime::Format::HTTP) = 0.36
* %files right

If you fix (or explain) the BuildRequires I'll approve




Comment 2 Chris Weyl 2006-08-06 16:23:48 UTC
Additional BuildRequires added; summary updated.

SRPM URL:
http://home.comcast.net/~ckweyl/perl-DateTime-Format-HTTP-0.36-2.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-DateTime-Format-HTTP.spec

Comment 3 Patrice Dumas 2006-08-06 20:25:03 UTC
The issues have been solved, so

APPROVED

Comment 4 Chris Weyl 2006-08-07 01:25:46 UTC
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4,FC-5)
+Close bug

Thanks for the review! :)


Note You need to log in before you can comment on or make changes to this bug.