Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 201491

Summary:	Review Request: perl-Module-Starter
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Patrice Dumas <pertusus>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Module-Starter
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-08-07 14:38:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 201493

Description Chris Weyl 2006-08-06 07:52:58 UTC

SRPM URL: http://home.comcast.net/~ckweyl/perl-Module-Starter-1.42-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Module-Starter.spec

Description:
This is a CPAN module/utility to assist in the creation of new modules in a
sensible and sane fashion.  Unless you're interested in extending the
functionality of this module, you should examine the documentation for
'module-starter', for information on how to use this tool.

It is noted that there are a number of extensions to this tool, including
plugins to create modules using templates as recommended by Damian Conway's
"Perl Best Practices" (O'Reilly, 2005).  (See also the package
perl-Module-Starter-PBP for the aformentioned templates.)

Comment 1 Patrice Dumas 2006-08-06 20:46:08 UTC

blocker:
For the tests, needed buildrequires:
Test::Pod::Coverage >= 1.04, Test::Pod >= 1.14

remark:
instead of 
%{_bindir}/*
you could have
%{_bindir}/module-starter
such that you notice if a new binary is distributed in later versions.

Otherwise:
* rpmlint is silent
* package named according to guidelines
* free software, licences not included
* meets packaging guidelines
* spec legible
* source match upstream
baf4a379d93c3a49c90a889626783d88  Module-Starter-1.42.tar.gz
* sane provides
perl(Module::Starter) = 1.42 perl(Module::Starter::Plugin::Template) = 0.02
perl(Module::Starter::Simple) = 1.42
* %files right

I'll approve if you fix (or explain) the BuildRequires.

Comment 2 Chris Weyl 2006-08-07 01:14:32 UTC

Added additional buildrequires for tests:

SRPM URL: http://home.comcast.net/~ckweyl/perl-Module-Starter-1.42-2.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Module-Starter.spec

Comment 3 Patrice Dumas 2006-08-07 08:27:40 UTC

APPROVED

Comment 4 Chris Weyl 2006-08-07 14:38:14 UTC

+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4, FC-5)
+Close bug

Thanks for the review! :)