Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 201842
| Summary: | Review Request: plotutils - GNU plotutils graphics libs and utils | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Denis Leroy <denis> |
| Component: | Package Review | Assignee: | Paul F. Johnson <paul> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-08-18 11:40:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 196510 | ||
|
Description
Denis Leroy
2006-08-09 12:27:32 UTC
Looking at the spec file You need Requires (post) : ldconfig unless you change post to be -p /sbin/ldconfig mkdir docs-to-include Where exactly does that get made? Why not just create a directory in the buildroot and shift from there rather than interfere with the dearchived source? This is not a complaint, just a suggestion. Other than patches, doing things in the BUILD I've always considered a bad idea (TM) rpmlint on the src package is giving the warning that you've mixed spaces with tabs builds cleaning in mock installs cleanly using yun localinstall rpm -qa --requires is not showing anything untoward I'll need to do the full review when I'm sitting infront of the machine. Can you address the mixed spaces and tabs and just upload a new spec file? SPEC: http://www.poolshark.org/src/plotutils.spec SRPM: http://www.poolshark.org/src/plotutils-2.5-2.src.rpm > warning that you've mixed spaces with tabs Somehow I always get that even when I use tabs everywhere! :-) Fixed. > You need Requires (post) : ldconfig Fixed. > mkdir docs-to-include I think it's a pretty harmless trick to add directories straight into /usr/share/doc/%{name}. I use that already in the gtkmm packages. Now I'm not sure it would work the same way if you created it under BUILDROOT, because %doc works differently if you give it a relative or absolute path, and the relative path is always from the source dir... I think you'd have to explicitely move things from %{_datadir} into %{_docdir}/%{name}/ after installation. Ping :-) (we're so close!) Sorry - not been that well recently, I'm usually out of it by about 9.30pm (British Summer Time). It's 2nd on my list for tomorrow's reviews. Who knows, it may even be good to go (TM) by this time tomorrow! Good Software works (tested against Ortep) Consistent use of macros Includes documentation No static libs/.la files No dupes from the rpms spec file in american english rpmlint clean mock builds fine Includes devel file, no .pc file, so no pkgconfig required for devel Correct use of scriptlets Dist tag fine Doesn't leave a mess when deinstalling I'm happy with this. APPROVED Please remember to close the bug and change the tab to NEXT-RELEASE. Paul, thanks for your review! |