Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 205138
| Summary: | Review Request: libjingle - GoogleTalk implementation of Jingle | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brian Pepple <bdpepple> |
| Component: | Package Review | Assignee: | Paul F. Johnson <paul> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | guillaume.desmottes |
| Target Milestone: | --- | Flags: | j:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-09-10 22:16:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Brian Pepple
2006-09-04 16:41:33 UTC
rpmlint output srpm W: mixed-spaces-and-tabs (ignorable) devel W: no-documentation (ignorable) mock builds fine o you have something I can link this against to test it? Not yet. Eventually, I'll be submitting farsight, but that will need some additional packages. Is this going to get a review? If not, this should remain FE-NEW so others can pick it up if they wish. Had machine problems last night - I'll review it later today Review
Good
Consistent use of macros
Software compiles happily in mock with no errors in rpmlint
Installs fine
Spec in US English and UTF-8
No permissions problems
No dupes in the rpms
Upstream tarball matches dist tarball md5
Includes documentation
No .a or .la files in the rpms
Minor - not a blocker, but it makes things easier on the eye
%{_libdir}/pkgconfig/jinglebase-0.3.pc
%{_libdir}/pkgconfig/jinglep2p-0.3.pc
%{_libdir}/pkgconfig/jinglesession-0.3.pc
%{_libdir}/pkgconfig/jinglexmllite-0.3.pc
%{_libdir}/pkgconfig/jinglexmpp-0.3.pc
Can be globbed - %{_libdir}/pkgconfig/jingle*.pc
I'm unable to test the code with anything extensive, but a simple bit of C
showed that it would link and do as it's told.
APPROVED
Package Change Request ====================== Package Name: libjingle New Branches: OLPC2 Updated Fedora Owners: gdesmott bpepple CVS done. |