Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 205138 - Review Request: libjingle - GoogleTalk implementation of Jingle
Summary: Review Request: libjingle - GoogleTalk implementation of Jingle
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul F. Johnson
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-09-04 16:41 UTC by Brian Pepple
Modified: 2008-04-23 16:21 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-10 22:16:23 UTC
Type: ---
Embargoed:
j: fedora-cvs+

Attachments (Terms of Use)

Description Brian Pepple 2006-09-04 16:41:33 UTC 
Spec URL: http://piedmont.homelinux.org/fedora/telepathy/libjingle.spec
SRPM URL: http://piedmont.homelinux.org/fedora/telepathy/libjingle-0.3.10-1.src.rpm
Description: Libjingle is Google Talk's implementation of Jingle and Jingle-Audio
(proposed extensions to XMPP) to interoperate with Google Talk's
peer-to-peer and voice calling capabilities.
Comment 1 Paul F. Johnson 2006-09-04 20:39:56 UTC 
rpmlint output
srpm
W: mixed-spaces-and-tabs (ignorable)

devel
W: no-documentation (ignorable)

mock builds fine

o you have something I can link this against to test it?
Comment 2 Brian Pepple 2006-09-04 21:30:48 UTC 
Not yet.  Eventually, I'll be submitting farsight, but that will need some
additional packages.
Comment 3 Brian Pepple 2006-09-06 16:53:21 UTC 
Is this going to get a review?  If not, this should remain FE-NEW so others can
pick it up if they wish.
Comment 4 Paul F. Johnson 2006-09-06 17:02:20 UTC 
Had machine problems last night - I'll review it later today
Comment 5 Paul F. Johnson 2006-09-10 15:19:32 UTC 
Review

Good

Consistent use of macros
Software compiles happily in mock with no errors in rpmlint
Installs fine
Spec in US English and UTF-8
No permissions problems
No dupes in the rpms
Upstream tarball matches dist tarball md5
Includes documentation
No .a or .la files in the rpms

Minor - not a blocker, but it makes things easier on the eye
%{_libdir}/pkgconfig/jinglebase-0.3.pc
%{_libdir}/pkgconfig/jinglep2p-0.3.pc
%{_libdir}/pkgconfig/jinglesession-0.3.pc
%{_libdir}/pkgconfig/jinglexmllite-0.3.pc
%{_libdir}/pkgconfig/jinglexmpp-0.3.pc

Can be globbed - %{_libdir}/pkgconfig/jingle*.pc

I'm unable to test the code with anything extensive, but a simple bit of C
showed that it would link and do as it's told.

APPROVED
Comment 6 Brian Pepple 2008-04-23 15:39:39 UTC 
Package Change Request
======================
Package Name: libjingle
New Branches: OLPC2
Updated Fedora Owners: gdesmott bpepple
Comment 7 Jason Tibbitts 2008-04-23 16:21:17 UTC 
CVS done.
Note You need to log in before you can comment on or make changes to this bug.