Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 206872
| Summary: | Review Request: sipsak - SIP swiss army knife | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | petersen:
fedora-cvs+
|
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-10-07 07:04:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Peter Lemenkov
2006-09-17 15:17:13 UTC
The main difficuty with this package is its options. It can be compiled with internal MD5 routines, with OpenSSL-based ones or even with GnuTLS. I have no idea which one is better. Guys from Mandriva used internal MD5 routines, but I prefer more modularity and reuse of components. Another one alternative is DNS-related part. Sipsak allows us to choose betwee c-ares (already in FE) and RULI-library (which isn't in FE still). So I prefer first variant here. (In reply to comment #1) > The main difficuty with this package is its options. It can be compiled with > internal MD5 routines, with OpenSSL-based ones or even with GnuTLS. I have no > idea which one is better. Guys from Mandriva used internal MD5 routines, but I > prefer more modularity and reuse of components. Your choice is no problem. With openssl-devel installed, configure defines "HAVE_EXTERNAL_MD5". Then md5.c is then essectially empty and this package uses surely "external" openssl routine. I will do full review later. First review of this package. 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Licensing - Add "COPYING" to binary. This is a MUST item. * Changelogs - Don't use macros (i.e. don't use %{?dist}). Note: adding %{?dist} to Changelog is not necessary. 2. http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing. Fix the two things above. Other things are okay. -------------------------------------------------------- This package (sipsak) is APPROVED by me. All done. Thanks for review! Changing summary for tracking purposes. Package Change Request ====================== Package Name: sipsak New Branches: EL-4 EL-5 added |