Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 206872 - Review Request: sipsak - SIP swiss army knife
Summary: Review Request: sipsak - SIP swiss army knife
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-09-17 15:17 UTC by Peter Lemenkov
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-10-07 07:04:41 UTC
Type: ---
Embargoed:
petersen: fedora-cvs+


Attachments (Terms of Use)

Description Peter Lemenkov 2006-09-17 15:17:13 UTC
Spec URL: http://lemenkov.newmail.ru/SPECS/sipsak.spec
SRPM URL: http://lemenkov.newmail.ru/SRPMS/sipsak-0.9.6-1.src.rpm

Description: sipsak is a small command line tool for developers and
administrators of Session Initiation Protocol (SIP) applications.
It can be used for some simple tests on SIP applications and
devices.

Comment 1 Peter Lemenkov 2006-09-17 17:20:20 UTC
The main difficuty with this package is its options. It can be compiled with
internal MD5 routines, with OpenSSL-based ones or even with GnuTLS. I have no
idea which one is better. Guys from Mandriva used internal MD5 routines, but I
prefer more modularity and reuse of components.

Another one alternative is DNS-related part. Sipsak allows us to choose betwee
c-ares (already in FE) and RULI-library (which isn't in FE still). So I prefer
first variant here.

Comment 2 Mamoru TASAKA 2006-10-05 13:29:24 UTC
(In reply to comment #1)
> The main difficuty with this package is its options. It can be compiled with
> internal MD5 routines, with OpenSSL-based ones or even with GnuTLS. I have no
> idea which one is better. Guys from Mandriva used internal MD5 routines, but I
> prefer more modularity and reuse of components.

Your choice is no problem. With openssl-devel installed, configure
defines "HAVE_EXTERNAL_MD5". Then md5.c is then essectially empty
and this package uses surely "external" openssl routine.

I will do full review later.

Comment 3 Mamoru TASAKA 2006-10-05 14:39:10 UTC
First review of this package.

1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Licensing
  - Add "COPYING" to binary. This is a MUST item.

* Changelogs
  - Don't use macros (i.e. don't use %{?dist}). Note:
    adding %{?dist} to Changelog is not necessary.

2. http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
  = Nothing.

Fix the two things above. Other things are okay.

--------------------------------------------------------
   This package (sipsak) is APPROVED by me.

Comment 4 Peter Lemenkov 2006-10-07 07:04:07 UTC
All done. Thanks for review!


Comment 5 Kevin Fenzi 2006-12-22 03:10:29 UTC
Changing summary for tracking purposes. 

Comment 6 Peter Lemenkov 2007-07-24 08:59:32 UTC
Package Change Request
======================
Package Name: sipsak
New Branches: EL-4 EL-5

Comment 7 Jens Petersen 2007-07-24 14:52:00 UTC
added


Note You need to log in before you can comment on or make changes to this bug.