Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 210788 (pear-Date-Holidays)

Summary:	Review Request: php-pear-Date-Holidays - Driver based class to calculate holidays
Product:	[Fedora] Fedora	Reporter:	Christopher Stone <chris.stone>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Flags:	jwboyer: fedora-cvs+
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-10-29 04:38:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	210787
Bug Blocks:	163779

Description Christopher Stone 2006-10-15 01:02:34 UTC

Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Date-Holidays.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Date-Holidays-0.16.1-1.src.rpm

Description:
Date_Holidays helps you calculating the dates and titles of holidays and
other special celebrations. The calculation is driver-based so it is easy
to add new drivers that calculate a country's holidays. The methods of the
class can be used to get a holiday's date and title in various languages.

Comment 1 Jason Tibbitts 2006-10-29 04:15:01 UTC

* source files match upstream:
   84dcf7f0c92afdf08b9c1d761a8ca89f  Date_Holidays-0.16.1.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-pear(Date_Holidays) = 0.16.1
   php-pear-Date-Holidays = 0.16.1-1.fc7
  =
   /bin/sh
   /usr/bin/pear
   /usr/bin/php
   php-pear(Console_Getargs)
   php-pear(Date)
   php-pear(PEAR)
   php-pear(XML_Serializer)
* %check is not present.  Test suite run manually and all tests pass:
   TestCase Date_Holidays_TestSuite->testFactory() passed
   TestCase Date_Holidays_TestSuite->testFactoryISO3166() passed
   TestCase Date_Holidays_Driver_TestSuite->testAddCompiledTranslationFile() passed
   TestCase Date_Holidays_Driver_TestSuite->testAddTranslationFile() passed
   TestCase Date_Holidays_Driver_TestSuite->testIsHoliday() passed
   TestCase Date_Holidays_Driver_TestSuite->testGetHolidays() passed
   TestCase Date_Holidays_Driver_TestSuite->testGetHoliday() passed
   TestCase Date_Holidays_Driver_TestSuite->testGetHolidayDate() passed
   TestCase Date_Holidays_Driver_TestSuite->testGetHolidayDates() passed
   TestCase Date_Holidays_Driver_TestSuite->testGetHolidayForDate() passed
   TestCase Date_Holidays_Driver_TestSuite->testGetHolidayProperties() passed
   TestCase Date_Holidays_Driver_TestSuite->testGetHolidaysForDatespan() passed
   TestCase Date_Holidays_Driver_TestSuite->testGetHolidayTitle() passed
   TestCase Date_Holidays_Driver_TestSuite->testGetHolidayTitles() passed
   TestCase Date_Holidays_Driver_TestSuite->testGetInternalHolidayNames() passed
   TestCase Date_Holidays_Driver_TestSuite->testGetYear() passed
   TestCase Date_Holidays_Driver_TestSuite->testSetYear() passed
   TestCase Date_Holidays_Driver_Christian_TestSuite->testHolidays2005() passed
   TestCase Date_Holidays_Driver_Germany_TestSuite->testHolidays2005() passed
   TestCase Date_Holidays_Driver_Germany_TestSuite->testHolidays2006() passed
   TestCase
Date_Holidays_Driver_Germany_TestSuite->testHolidays2005stampsAndSavingsDay() passed
   TestCase Date_Holidays_Driver_Jewish_TestSuite->testHolidays2005() passed
   TestCase Date_Holidays_Driver_PHPdotNet_TestSuite->testHolidays2005() passed
   TestCase Date_Holidays_Driver_UNO_TestSuite->testHolidays2005() passed
   TestCase Date_Holidays_Driver_USA_TestSuite->test_holidays_2005() passed
   TestCase Date_Holidays_Driver_USA_TestSuite->test_holidays_2004() passed
   TestCase Date_Holidays_Driver_USA_TestSuite->test_holidays_2006() passed
   TestCase Date_Holidays_Driver_USA_TestSuite->test_holidays() passed
   TestCase Date_Holidays_Driver_Sweden_TestSuite->testHolidays2005() passed
   TestCase Date_Holidays_Driver_Sweden_TestSuite->testHolidays2006() passed
   TestCase Date_Holidays_Driver_Sweden_TestSuite->testGermanTranslations() passed
   TestCase
Date_Holidays_Driver_Sweden_TestSuite->testcompiledGermanTranslations() passed

* owns the directories it creates.  (/usr/share/pear/Date is owned by a dependency).
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets OK (pear module installation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 2 Christopher Stone 2006-10-29 04:38:50 UTC

Built for devel, will look into seeing if I can run the tests in %check.  Thanks
for the review.

Comment 3 Christopher Stone 2007-04-21 17:53:57 UTC

Branch Package CVS Request
=======================
Package Name: php-pear-Date-Holidays
Short Description: Driver based class to calculate holidays
Owners: chris.stone
Branches: EL-5
InitialCC: