Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 212502
Summary: | Review Request: perl-Chatbot-Eliza - Clone of the classic Eliza program | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Patrice Dumas <pertusus> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Chatbot-Eliza/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-10-27 22:25:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chris Weyl
2006-10-27 02:06:36 UTC
* rpmlint is silent * free software, licence not included * spec legible * simple perl module, no BuildRequires needed * match upstream 754199bbe591eaa11301aee108586fcd Chatbot-Eliza-1.04.tar.gz * sane provides Provides: perl(Chatbot::Eliza) = 1.04 Needswork: The language specific files in %doc should be tagged with the appropriate %lang. Comment: Not a blocker, but I think that there could be a summary explaining better what it the module does. (In reply to comment #1) > Needswork: > > The language specific files in %doc should be tagged with the > appropriate %lang. Is this a blocker, given that they're sample files in %doc and named "deutsch" and "norsk"? Given that there's a couple sample files for those two languages, I suppose I could put them under, %doc/DE and %doc/NO? Would that suffice? No need to do that, I just ask for the following, instead of a plain %doc: %doc doctor.txt simple* README debug.cgi twobots %lang(de) %doc deutsch* %lang(??) %doc norsk* (In reply to comment #3) > No need to do that, I just ask for the following, instead of > a plain %doc: > > %doc doctor.txt simple* README debug.cgi twobots > %lang(de) %doc deutsch* > %lang(??) %doc norsk* Done: SRPM URL: http://home.comcast.net/~ckweyl/perl-Chatbot-Eliza-1.04-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Chatbot-Eliza.spec Out of curiosity, what does tagging these files in this fashion do? Looking at the resulting rpm I'm not seeing any difference. (In reply to comment #4) > Out of curiosity, what does tagging these files in this fashion do? Looking at > the resulting rpm I'm not seeing any difference. I don't know what it should do, and I believe it does nothing yet. In the summary, I think the s of elisa should be a z. APPROVED (In reply to comment #5) > In the summary, I think the s of elisa should be a z. Fixed, thanks. > APPROVED Imported & building for devel, branches requested for FC-5, FC-6. Thanks for the review! |