Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 214746 (eiciel)
Summary: | Review Request: eiciel - Graphical access control list (ACL) editor | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://rofi.pinchito.com/eiciel | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-12 05:06:51 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chris Weyl
2006-11-09 05:53:00 UTC
*** Bug 179758 has been marked as a duplicate of this bug. *** This is a resurrection of a stalled review. The issues brought up during the actual review (comment 23 of bug 179758) were addressed; otherwise the spec/package is the same. Ok. I will like to review this package. Still help file is showing 0.9.1 version Updated -- apparently upstream included an xml file they shouldn't have... SRPM URL: http://home.comcast.net/~ckweyl/eiciel-0.9.2-7.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/eiciel.spec Review: + package builds in mock (development i386) for FC6. + rpmlint is silent for RPM and SRPM. + source files match upstream. 72576cce092ff36a4fef0311bdc0dede eiciel-0.9.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written but NOT properly indented. + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + COPYING included in %doc. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc files. + no -devel subpackage exists + no .la files included. + translations are available. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed successfully + Desktop file is handled correctly in SPEC file. + GUI application APPROVED. Don't Forget to CLOSE this bug once you imported your package in CVS Imported and built for devel; branches requested for FC-5 and 6. Thanks for the review! |