Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 214746 (eiciel) - Review Request: eiciel - Graphical access control list (ACL) editor
Summary: Review Request: eiciel - Graphical access control list (ACL) editor
Keywords:
Status: CLOSED NEXTRELEASE
Alias: eiciel
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
URL: http://rofi.pinchito.com/eiciel
Whiteboard:
: 179758 (view as bug list)
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-11-09 05:53 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-12 05:06:51 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Chris Weyl 2006-11-09 05:53:00 UTC 
SRPM URL: http://home.comcast.net/~ckweyl/eiciel-0.9.2-6.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/eiciel.spec

Description:
Graphical editor for access control lists (ACL)
and extended attributes (XATTR), either as an
extension within Nautilus, or as a standalone utility.
Comment 1 Chris Weyl 2006-11-09 05:54:27 UTC 
*** Bug 179758 has been marked as a duplicate of this bug. ***
Comment 2 Chris Weyl 2006-11-09 06:00:00 UTC 
This is a resurrection of a stalled review.  The issues brought up during the
actual review (comment 23 of bug 179758) were addressed; otherwise the
spec/package is the same.
Comment 3 Parag AN(पराग) 2006-11-11 16:44:57 UTC 
Ok. I will like to review this package.
Comment 4 Parag AN(पराग) 2006-11-11 17:44:18 UTC 
Still help file is showing 0.9.1 version
Comment 5 Chris Weyl 2006-11-11 23:23:47 UTC 
Updated -- apparently upstream included an xml file they shouldn't have...

SRPM URL: http://home.comcast.net/~ckweyl/eiciel-0.9.2-7.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/eiciel.spec
Comment 6 Parag AN(पराग) 2006-11-12 04:44:48 UTC 
Review:
+ package builds in mock (development i386) for FC6.
+ rpmlint is silent for RPM and SRPM.
+ source files match upstream.
72576cce092ff36a4fef0311bdc0dede  eiciel-0.9.2.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written but NOT properly indented.
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ COPYING included in %doc.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc files.
+ no -devel subpackage exists
+ no .la files included.
+ translations are available.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop file installed successfully
+ Desktop file is handled correctly in SPEC file.
+ GUI application
APPROVED.
Comment 7 Parag AN(पराग) 2006-11-12 04:47:17 UTC 
Don't Forget to CLOSE this bug once you imported your package in CVS
Comment 8 Chris Weyl 2006-11-12 05:06:51 UTC 
Imported and built for devel; branches requested for FC-5 and 6.

Thanks for the review!
Note You need to log in before you can comment on or make changes to this bug.