Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 217225
Summary: | Review Request: perl-Apache-DBI - Initiate a persistent database connection | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
Component: | Package Review | Assignee: | Ville Skyttä <ville.skytta> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | wtogami:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-25 13:14:11 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Remi Collet
2006-11-25 10:00:44 UTC
The perldoc generated license files are not needed, and should go. Instead, it would be a good idea to ask upstream to include license files in the distribution. Improved Summary suggestion: Persistent database connections with Apache/mod_perl How about a "Requires: mod_perl"? I'm not sure if this package would work at all without it, but I suppose at least it's not that useful without it. OPTIMIZE="$RPM_OPT_FLAGS" should go, this is a noarch package. Include traces.txt and eg/ in docs? Remember to do something like this in %prep: %{__perl} -pi -e 's|/usr/local/bin/perl|%{__perl}|' eg/startup.pl chmod 644 eg/startup.pl > How about a "Requires: mod_perl"? I'm not sure if this package would work at > all without it, but I suppose at least it's not that useful without it. It can be used in cgi mode, so without mod_perl (ok, not very usefull). Other perl-Apache extension didn't require it too. Spec URL: http://remi.collet.free.fr/rpms/extras/perl-Apache-DBI.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/perl-Apache-DBI-1.05-2.fc7.src.rpm Mock Log: http://remi.collet.free.fr/rpms/extras/perl-Apache-DBI-build.log Changes - no more perldoc - no more OPTIMIZE - traces.txt & eg/ add to %doc - Improved Summary Ok, approved. Package Change Request ====================== Package Name: perl-Apache-DBI New Branches: EL-5 EL-4 |