Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 217225 - Review Request: perl-Apache-DBI - Initiate a persistent database connection
Summary: Review Request: perl-Apache-DBI - Initiate a persistent database connection
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ville Skyttä
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-11-25 10:00 UTC by Remi Collet
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-25 13:14:11 UTC
Type: ---
Embargoed:
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Remi Collet 2006-11-25 10:00:44 UTC 
Spec URL: http://remi.collet.free.fr/rpms/extras/perl-Apache-DBI.spec
SRPM URL: http://remi.collet.free.fr/rpms/extras/perl-Apache-DBI-1.05-1.fc7.src.rpm
Mock Log: http://remi.collet.free.fr/rpms/extras/perl-Apache-DBI-build.log
Description: 
This is version 1.05 of Apache::AuthDBI and Apache::DBI.

These modules are supposed to be used with the Apache server together with
an embedded perl interpreter like mod_perl. They provide support for basic
authentication and authorization as well as support for persistent database
connections via Perl's Database Independent Interface (DBI).

o DBI.pm provides persistent database connections:
  - connections can be established during server-startup
  - configurable rollback to ensure data integrity
  - configurable verification of the connections to avoid time-outs.

o AuthDBI.pm provides authentication and authorization:
  - optional shared cache for passwords to minimize database load
  - configurable cleanup-handler deletes outdated entries from the cache

Apache::DBI has been in widespread deployment on many platforms for
years.  Apache::DBI is one of the most widely used mod_perl related
modules.  It can be considered stable.

---
I'm not used to package PERL extension, but this one is needed by a project i work on (ocsinventory).
Comment 1 Ville Skyttä 2006-11-25 10:19:57 UTC 
The perldoc generated license files are not needed, and should go.  Instead, it
would be a good idea to ask upstream to include license files in the distribution.

Improved Summary suggestion: Persistent database connections with Apache/mod_perl

How about a "Requires: mod_perl"?  I'm not sure if this package would work at
all without it, but I suppose at least it's not that useful without it.

OPTIMIZE="$RPM_OPT_FLAGS" should go, this is a noarch package.

Include traces.txt and eg/ in docs?  Remember to do something like this in %prep:
    %{__perl} -pi -e 's|/usr/local/bin/perl|%{__perl}|' eg/startup.pl
    chmod 644 eg/startup.pl
Comment 2 Remi Collet 2006-11-25 11:07:41 UTC 
> How about a "Requires: mod_perl"?  I'm not sure if this package would work at
> all without it, but I suppose at least it's not that useful without it.
It can be used in cgi mode, so without mod_perl (ok, not very usefull).
Other perl-Apache extension didn't require it too.

Spec URL: http://remi.collet.free.fr/rpms/extras/perl-Apache-DBI.spec
SRPM URL: http://remi.collet.free.fr/rpms/extras/perl-Apache-DBI-1.05-2.fc7.src.rpm
Mock Log: http://remi.collet.free.fr/rpms/extras/perl-Apache-DBI-build.log

Changes
- no more perldoc
- no more OPTIMIZE
- traces.txt & eg/ add to %doc
- Improved Summary
Comment 3 Ville Skyttä 2006-11-25 12:43:47 UTC 
Ok, approved.
Comment 4 Remi Collet 2007-05-16 12:38:43 UTC 
Package Change Request
======================
Package Name: perl-Apache-DBI 
New Branches: EL-5 EL-4
Note You need to log in before you can comment on or make changes to this bug.