Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 217557
| Summary: | Review Request: keurocalc - KEuroCalc is a universal currency converter and calculator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chitlesh GOORAH <chitlesh> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | rdieter |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-12-23 23:57:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Chitlesh GOORAH
2006-11-28 16:56:40 UTC
Please check the URL you have provided. On both of them I get: Keine Berechtigung. Richte auch du Deine kostenlose Homepage beim kostenlosen Webspace bei Funpic.de ein. taking this for review for some reason, i could access it, perhaps because it's an alias. http://chitlesh.ch.funpic.de/fedora/SPECS/keurocalc.spec http://chitlesh.ch.funpic.de/fedora/SRPM/keurocalc-0.9.7-1.src.rpm Sorry there was middle-air-collision:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776 |163778
nThis| |
Fixing it up.
Just retried from several different places, via diferent internet providers. FRom None of them was the link accessible. All end in something similar to 19:38:23 (110 MB/s) - `403.html' saved [1777/1777] Chitlesh thanks.
manuel wolfshant,
It worked for me without problem. Infact links in initial and comment 3 are
both working for me.
manuel wolfshant, check these http://strasbourg.linuxfr.org/~chit/keurocalc.spec http://strasbourg.linuxfr.org/~chit/keurocalc-0.9.7-1.src.rpm Thanks, these ones do work. Chitlesh, Just did build (NOT mock)on my i386 system and I got many rpmlint warnings on binary i386 rpm 1)Got many The symbolic link points nowhere warnings. 2)can you check following command output and correct desktop file? desktop-file-validate keurocalc.desktop I don't think i need to specify all them here. Time for me to go bed. Rest will see tomorrow. > 1)Got many The symbolic link points nowhere warnings. Mostly harmless. It is not uncommon for kde apps to symlink to bits in kdelibs >2)can you check following command output and correct desktop file? >desktop-file-validate keurocalc.desktop desktop-file-utils is buggy wrt many kde .desktop files, see bug #212350 and bug #172423 . Don't take it's warnings/errors as gospel. thanks for that information Rex But i do found something done for symlink warnings in bug #213432 is that similar to this case? You mean simply changing absolute symlinks to relative ones? (In reply to comment #13) > You mean simply changing absolute symlinks to relative ones? is that possible and will be working in kde package case.? Anyways here comes Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and but NOT for RPMS. But those warnings can be ignored as said in comment #10. + source files match upstream. d2e22dcbba267549bf3a93ed8bf715c2 keurocalc-0.9.7.tgz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + COPYING included in %doc. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel or any subpackages exists + no .la files. + no translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop files are not handled in usual way but its ok. + Used properly gtk-update-icon-cache scriptlet Looks like its not possible. APPROVED. Don't forget to close this bug as NEXTRELEASE. ## File lists
# locale's
%find_lang %{name} || touch %{name}.lang
# HTML (1.0)
HTML_DIR=$(kde-config --expandvars --install html)
if [ -d $RPM_BUILD_ROOT$HTML_DIR ]; then
for lang_dir in $RPM_BUILD_ROOT$HTML_DIR/* ; do
if [ -d $lang_dir ]; then
lang=$(basename $lang_dir)
echo "%lang($lang) $HTML_DIR/$lang/*" >> %{name}.lang
# replace absolute symlinks with relative ones
pushd $lang_dir
for i in *; do
[ -d $i -a -L $i/common ] && rm -f $i/common && ln -sf ../common
$i/common
done
popd
fi
done
fi
Will make them relative
Thanks Denis Any reason behind not closing this bug? Yes, I don't have an internet connection with certain ports opened. :( I'll close thiss bug soon. Are you willing to implement solution given it https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217557#c17? Yes, I have thanks |