Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 172423 - "Keywords" validated as string, not localestring
Summary: "Keywords" validated as string, not localestring
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: desktop-file-utils
Version: rawhide
Hardware: All
OS: Linux
medium
low
Target Milestone: ---
Assignee: Ray Strode [halfline]
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-11-04 08:30 UTC by Ville Skyttä
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-07 16:41:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Validate "Keywords" as localestring (939 bytes, patch)
2005-11-04 08:30 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2005-11-04 08:30:06 UTC
The value of the "Keywords" key in desktop entry files is validated as string,   
which is not too useful for localized keywords.   
   
I don't know of a specification that would define exactly what the "Keywords"   
key may contain, but the possibility of localizing the keywords would sound 
sane to me, and ASCII doesn't work for that purpose.   
   
A problem caused by this:   
https://www.redhat.com/archives/fedora-extras-list/2005-November/msg00197.html   
   
Suggested patch against f.d.o CVS attached.  Reported here because there's no   
component for desktop-file-utils in bugs.freedesktop.org.  (That's  
https://bugs.freedesktop.org/show_bug.cgi?id=4959)

Comment 1 Ville Skyttä 2005-11-04 08:30:07 UTC
Created attachment 120717 [details]
Validate "Keywords" as localestring

Comment 2 Ray Strode [halfline] 2006-11-07 16:38:03 UTC
So the only reference I can find to the use of Keywords, is here:

http://standards.freedesktop.org/desktop-entry-spec/latest/apb.html

It doesn't say what type it is, so if we're finding localestrings in the wild I
guess your patch makes sense.

Comment 3 Ray Strode [halfline] 2006-11-07 16:41:22 UTC
committed.

Comment 4 Rex Dieter 2006-11-29 02:27:13 UTC
This affects packaging of many kde applications.  
Can we expect a fixed desktop-file-utils to land in fedora soon?

Comment 5 Ray Strode [halfline] 2006-11-29 03:21:57 UTC
Should be in tomorrow's rawhide.  Sorry for the delay; I thought I had already
pushed it to rawhide.


Note You need to log in before you can comment on or make changes to this bug.