Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 219751
Summary: | Review Request: python-TurboMail - Multi-threaded mail queue manager for TurboGears applications. | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
Component: | Package Review | Assignee: | José Matos <jamatos> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | pfrields |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-12-16 20:43:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Luke Macken
2006-12-15 05:32:32 UTC
The spec looks really clean, just one small comment (nitpicking :-): If the package is noarch why do you need to set the CFLAGS? :-) No need to change the spec because of this detail you do it when importing. The full review will follow soon. Building fails in mock because the spec file is missing BuildRequires: python-setuptools OK, better yet, make that BuildRequires: TurboGears since the installation requires it to be present. Assuming that my previous suggestion is followed this is the revision: ---------------------------------------- Review for release 1: * RPM name is OK * Source TurboMail-2.0.3.tar.gz is the same as upstream * Builds fine in mock * rpmlint looks OK * File list looks OK * License is correct (MIT) and OK for Fedora * Spec is clear and well written Needs work: * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) Notes: superfuluous CFLAGS when building. BR TurboGears If you merge these two changes the package is APPROVED. You can do the changes when importing. After the building of this package do not forget to close this bug as NEXTRELEASE. http://people.redhat.com/lmacken/SPECS/python-TurboMail.spec http://people.redhat.com/lmacken/SRPMS/python-TurboMail-2.0.3-2.src.rpm * Fri Dec 15 2006 Luke Macken <lmacken> 2.0.3-2 - Add TurboGears to BuildRequires - Remove superfluous CFLAGS - Add LICENSE.txt Imported into CVS, added to owners.list, requested FC-6 CVS branch, tagged and built for devel. Thanks! |