Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 219751 - Review Request: python-TurboMail - Multi-threaded mail queue manager for TurboGears applications.
Summary: Review Request: python-TurboMail - Multi-threaded mail queue manager for Turb...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-12-15 05:32 UTC by Luke Macken
Modified: 2016-09-20 02:37 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-12-16 20:43:02 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Luke Macken 2006-12-15 05:32:32 UTC 
Spec URL: http://people.redhat.com/lmacken/SPECS/python-TurboMail.spec
SRPM URL: http://people.redhat.com/lmacken/SRPMS/python-TurboMail-2.0.3-1.src.rpm
Description:
TurboMail is a TurboGears extension, meaning that it starts up and shuts down
alongside any TurboGears applications you write, in the same way that visit
tracking and identity do. TurboMail uses built-in Python modules for SMTP
communication and MIME e-mail creation, but greatly simplifies these tasks by
performing the grunt-work for you. Additionally, TurboMail is multi-threaded,
allowing for single or batch enqueueing and background delivery of mail.
Comment 1 José Matos 2006-12-15 09:26:38 UTC 
The spec looks really clean, just one small comment (nitpicking :-):

If the package is noarch why do you need to set the CFLAGS? :-)

No need to change the spec because of this detail you do it when importing.

The full review will follow soon.
Comment 2 José Matos 2006-12-15 23:11:12 UTC 
Building fails in mock because the spec file is missing 
BuildRequires:  python-setuptools
Comment 3 José Matos 2006-12-15 23:16:05 UTC 
OK, better yet, make that
BuildRequires:   TurboGears

since the installation requires it to be present.
Comment 4 José Matos 2006-12-15 23:53:09 UTC 
Assuming that my previous suggestion is followed this is the revision:

----------------------------------------
Review for release 1:
* RPM name is OK
* Source TurboMail-2.0.3.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* License is correct (MIT) and OK for Fedora
* Spec is clear and well written

Needs work:
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)


Notes:
  superfuluous CFLAGS when building.
  BR TurboGears

If you merge these two changes the package is APPROVED. You can do the changes 
when importing.

After the building of this package do not forget to close this bug as 
NEXTRELEASE.
Comment 5 Luke Macken 2006-12-16 20:43:02 UTC 
http://people.redhat.com/lmacken/SPECS/python-TurboMail.spec
http://people.redhat.com/lmacken/SRPMS/python-TurboMail-2.0.3-2.src.rpm

* Fri Dec 15 2006 Luke Macken <lmacken> 2.0.3-2
- Add TurboGears to BuildRequires
- Remove superfluous CFLAGS
- Add LICENSE.txt

Imported into CVS, added to owners.list, requested FC-6 CVS branch, tagged and
built for devel.

Thanks!
Note You need to log in before you can comment on or make changes to this bug.