Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 220730
Summary: | Review Request: gpodder - Podcast receiver/catcher written in Python | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jef Spaleta <jspaleta> |
Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-12-28 06:48:15 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Jef Spaleta
2006-12-24 23:15:00 UTC
Jef, I'll get you a review for this later today. MD5Sum: 8c58c613d049bd2387e09876c574ebf9 gpodder-0.8.0.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * Files have appropriate permissions and owners * Rpmlint produces no warnings or errors. * Package builds in Mock fine. * Package installs and uninstalls cleanly on FC6 * Package seems to work fine, based on a quick test. Minor Items that should be fixed before building in FE: * Drop the 'X-Fedora-Extras' category from the desktop file. It was recently decided to drop the 'X-Fedora' & 'X-Fedora-Extras' categories. Refer to the example at http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 * Drop the Requires on Python, since it is redundant. The BR on python-devel will provide python(abi) = 2.4 automatically. Refer to your build logs for verification. Minor: * Close button on about window does not work. This isn't a blocker, but probably at a minimum should be reported upstream. +1 APPROVE Built in the development tree awaiting signing. Changed summary for tracking purposes. |