Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 220999 (pear-Net-Sieve)
Summary: | Review Request: php-pear-Net-Sieve - Communication with timsieved | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Brandon Holbrook <fedora> |
Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-12-31 05:58:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 220926 |
Description
Brandon Holbrook
2006-12-30 06:15:01 UTC
I'll review this (probably tomorrow). Two second glance at spec looks like you have the wrong license. Brandon, I'm seeing a couple little minor things that need fixing. Could you please redo this spec using the fedora-newrpmspec command? Just run fedora-newrpmsepc php-pear-Net-Sieve and it will create a default template for you to use. This will be much easier for me to review. Thanks. I don't mind regenerating a new spec file, but this one is almost verbatim the pear template found at: http://fedoraproject.org/wiki/Extras/SIGs/PHP/PearSpecTemplate If something is wrong with the template I'd rather point out specifics so the wiki can be updated as well as this package. Fixed. Thanks for pointing this out. Spec URL: http://theholbrooks.org/RPMS/php-pear-Net-Sieve.spec SRPM URL: http://theholbrooks.org/RPMS/php-pear-Net-Sieve-1.1.5-2.src.rpm Cleaned up to match the new template. Thanks for updating it Chris! I also changed the license to BSD (at least that's what it looked like in the header comment in Sieve.php) ==== REVIEW CHECKLIST ==== - rpmlint output: W: php-pear-Net-Sieve no-documentation permissible, no documentation - package named according to package naming guidelines - spec filename matches %{name} - package meets packaging guidelines - licensed with open source compatible license - license matches actual license - source package does not include license file - spec written in American english - spec file is legible - package successfully compiles and builds on FC6 x86_64 - all build dependices listed in BR - no locales - no shared libraries - package is not relocatable - packge owns all directories it creates - no duplicates in %files - file permissions set properly - package contains proper %clean section - macro usage is consistent - contains code - no large documentation - no %doc - no header files or static libraries - no pkgconfig files - no library files - no need for devel subpackage - no .la files - not a GUI app needing a .desktop file - packages shares directory ownership with other Net packages. Acceptable for pear packages APPROVED oops forgot one checklist item: - sources match upstream 2f0b868d5bde1742721d525233274f5a Net_Sieve-1.1.5.tgz APPROVED Thanks again Chris. Imported, built, FC[56] branches requested |