Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 221059
| Summary: | Review Request: cowsay - configurable speaking/thinking cow | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michał Bentkowski <mr.ecik> | ||||
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | jonstanley | ||||
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-01-02 20:49:56 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Michał Bentkowski
2006-12-31 18:43:29 UTC
Actually I know this application because I use this
for cowsaver, one of hacks which can be used for xscreensaver.
I will review this.
* Use "cp -p" to keep timestamps ("Timestamps" in
http://fedoraproject.org/wiki/Packaging/Guidelines )
* Please fix the description of man package according to
installed paths.
* How about randomize a cow which is choosen?
Created attachment 144618 [details]
wrapper script I use to randomize cowsay
c.f.
"animalsay", which I use for cowsaver to randomize
animal used by cowsay.
Thanks for review! I have uploaded new SRPM and Spec files: Spec URL: http://ecik.nonlogic.org/cowsay/cowsay.spec SRPM URL: http://ecik.nonlogic.org/cowsay/cowsay-3.03-2.src.rpm I hope it's good enough right now :) [tasaka1@localhost cowsay]$ cat 1.log | animalsay -W 100
_____________________________________________________________________________________________________
/ Thank you for adding my "animalsay" script!!
\
|
|
| Well, = rpmlint issue
|
|
|
| W: cowsay non-conffile-in-etc /etc/bash_completion.d/cowsay.bashcomp
|
|
|
| = This _must_ be ignored for this case. = Timestamps, man file description are
now okay. = License, |
| md5sum okay = Other things are also okay... accroding to
|
|
|
| http://fedoraproject.org/wiki/Packaging/Guidelines
|
|
|
| http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
|
|
|
| -----------------------------------------------------------
|
|
|
\ This package (cowsay) is APPROVED by me.
/
-----------------------------------------------------------------------------------------------------
\ ____
\ / \
| ^__^ |
| (oo) |______
| (__) | )\/\
\____/|----w |
|| ||
Moofasa
_____________________________________________________
/ I had to slightly modify animalsay script ;-) \
| |
| Thank you again for review! |
| |
| Package succesfully built for FC-5, FC-6 and devel. |
| |
\ Closing. /
-----------------------------------------------------
\
\
.--.
|o_o |
|:_/ |
// \ \
(| | )
/'\_ _/`\
\___)=(___/
Package Change Request
======================
Package Name: cowsay
Updated EPEL Owners: jstanley
New Branches: EL-4 EL-5
____________
< Thank You! >
------------
\
\
.--.
|o_o |
|:_/ |
// \ \
(| | )
/'\_ _/`\
\___)=(___/
cvs done. |