Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 221059 - Review Request: cowsay - configurable speaking/thinking cow
Summary: Review Request: cowsay - configurable speaking/thinking cow
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-12-31 18:43 UTC by Michał Bentkowski
Modified: 2008-05-05 21:56 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-01-02 20:49:56 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+

Attachments (Terms of Use)
wrapper script I use to randomize cowsay (319 bytes, text/plain)
2007-01-02 04:05 UTC, Mamoru TASAKA 		no flags Details
View All

Description Michał Bentkowski 2006-12-31 18:43:29 UTC 
Spec URL: http://ecik.nonlogic.org/cowsay/cowsay.spec
SRPM URL: http://ecik.nonlogic.org/cowsay/cowsay-3.03-1.src.rpm
Description:
cowsay is a configurable talking cow, written in Perl.  It operates
much as the figlet program does, and it written in the same spirit
of silliness.
It generates ASCII pictures of a cow with a message. It can also generate
pictures of other animals.

rpmlint gives following output:
W: cowsay non-conffile-in-etc /etc/bash_completion.d/cowsay.bashcomp
but that same output is given on rpmlint.rpm so it looks like we can ignore it.
Comment 1 Mamoru TASAKA 2007-01-02 03:58:47 UTC 
Actually I know this application because I use this
for cowsaver, one of hacks which can be used for xscreensaver.

I will review this.

* Use "cp -p" to keep timestamps ("Timestamps" in
  http://fedoraproject.org/wiki/Packaging/Guidelines )

* Please fix the description of man package according to
  installed paths.

* How about randomize a cow which is choosen?
Comment 2 Mamoru TASAKA 2007-01-02 04:05:00 UTC 
Created attachment 144618 [details]
wrapper script I use to randomize cowsay

c.f.

"animalsay", which I use for cowsaver to randomize
animal used by cowsay.
Comment 3 Michał Bentkowski 2007-01-02 17:39:04 UTC 
Thanks for review!
I have uploaded new SRPM and Spec files:
Spec URL: http://ecik.nonlogic.org/cowsay/cowsay.spec
SRPM URL: http://ecik.nonlogic.org/cowsay/cowsay-3.03-2.src.rpm

I hope it's good enough right now :)
Comment 4 Mamoru TASAKA 2007-01-02 18:37:01 UTC 
[tasaka1@localhost cowsay]$ cat 1.log | animalsay -W 100
 _____________________________________________________________________________________________________

/ Thank you for adding my "animalsay" script!!                                 
                      \
|                                                                              
                      |
| Well, = rpmlint issue                                                        
                      |
|                                                                              
                      |
| W: cowsay non-conffile-in-etc /etc/bash_completion.d/cowsay.bashcomp         
                      |
|                                                                              
                      |
| = This _must_ be ignored for this case. = Timestamps, man file description are
now okay. = License, |
| md5sum okay = Other things are also okay... accroding to                     
                      |
|                                                                              
                      |
| http://fedoraproject.org/wiki/Packaging/Guidelines                           
                      |
|                                                                              
                      |
| http://fedoraproject.org/wiki/Packaging/ReviewGuidelines                     
                      |
|                                                                              
                      |
| -----------------------------------------------------------                  
                      |
|                                                                              
                      |
\ This package (cowsay) is APPROVED by me.                                     
                      /
 -----------------------------------------------------------------------------------------------------

       \    ____
        \  /    \
          | ^__^ |
          | (oo) |______
          | (__) |      )\/\
           \____/|----w |
                ||     ||

                 Moofasa
Comment 5 Michał Bentkowski 2007-01-02 20:49:56 UTC 
 _____________________________________________________
/ I had to slightly modify animalsay script ;-)       \
|                                                     |
| Thank you again for review!                         |
|                                                     |
| Package succesfully built for FC-5, FC-6 and devel. |
|                                                     |
\ Closing.                                            /
 -----------------------------------------------------
   \
    \
        .--.
       |o_o |
       |:_/ |
      //   \ \
     (|     | )
    /'\_   _/`\
    \___)=(___/
Comment 6 Jon Stanley 2008-05-05 21:45:29 UTC 
Package Change Request
======================
Package Name: cowsay
Updated EPEL Owners: jstanley
New Branches: EL-4 EL-5

 ____________
< Thank You! >
 ------------
   \
    \
        .--.
       |o_o |
       |:_/ |
      //   \ \
     (|     | )
    /'\_   _/`\
    \___)=(___/
Comment 7 Kevin Fenzi 2008-05-05 21:56:36 UTC 
cvs done.
Note You need to log in before you can comment on or make changes to this bug.