Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 221947
| Summary: | Review Request: gwenhywfar - utility library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bill Nottingham <notting> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | rvokal |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | j:
fedora-review+
j: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-09 03:59:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Bill Nottingham
2007-01-09 06:25:35 UTC
rpmlint is not silent rpmlint on main RPM reported W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. rpmlint on -devel rpm reported I: gwenhywfar-devel checking E: gwenhywfar-devel only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. Otherwise mock build is fine. (In reply to comment #1) > W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt It's not really a configuration file, it's a data file. It's a CA certificate bundle, much like /etc/pki/tls/certs/ca-bundle.crt. However, that is also marked %config, so I'll change this. (Ideally it just uses the openssl CA bundle.) > E: gwenhywfar-devel only-non-binary-in-usr-lib > There are only non binary files in /usr/lib so they should be in /usr/share. This is a mis-error from rpmlint. It's a architecture-specific include, so it can't be in /usr/include, and needs to be in an architecture specific directory. See glib2, dbus, gcc, qt for other examples of this. (In reply to comment #2) > (In reply to comment #1) > > W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt > > It's not really a configuration file, it's a data file. It's a CA certificate > bundle, much like /etc/pki/tls/certs/ca-bundle.crt. However, that is > also marked %config, so I'll change this. Perhaps it should live in /etc/pki/tls/certs too? It's not easily modifiable without patching, and if I'm going to do that, I'd rather just patch it to *use* the openssl one. Currently discussing that w/upstream. FWIW, curl uses the openssl one rather than the one shipped in the curl tarball... 2.3.0-6 uploaded; cert bundle marked as config, rpaths fixed. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM. - rpmlint is NOT silent for RPMS. E: gwenhywfar-devel only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. But its ok as it looks mis-error by rpmlint. + source files match upstream. 0f7cf7d0efa6719f85c00d6d8ccec2b3 gwenhywfar-2.3.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code Not contents. + no static libraries present. + no gwenhywfar.pc files present. + -devel subpackage exists + included %post -p /sbin/ldconfig %postun -p /sbin/ldconfig + no .la files. + translations are available + Dose owns the directories it creates. + no duplicates in %files. + no scriptlets used. + file permissions are appropriate. APPROVED. Just looking over: (In reply to comment #7) > + no gwenhywfar.pc files present. It certainly has them in my builds... (In reply to comment #8) > Just looking over: > > (In reply to comment #7) > > + no gwenhywfar.pc files present. > > It certainly has them in my builds... oops Sorry. I actually used to copy my Review Template and modify them according to package. I forgot to remove no word. Ping any problem for importing this package to CVS? Just waiting for the round tuits. Will get to it this week-ish. This is built now. Package Change Request ====================== Package Name: gwenhywfar New Branches: EL-4 EL-5 CVS done. |