Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 228468
Summary: | Review Request: hunspell-da - Danish hunspell dictionaries | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Caolan McNamara <caolanm> |
Component: | Package Review | Assignee: | manuel wolfshant <wolfy> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | wolfy |
Target Milestone: | --- | Flags: | wolfy:
fedora-review+
notting: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-02-14 09:48:15 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Caolan McNamara
2007-02-13 09:21:32 UTC
This package does not include the most recent upstream version of the files and therefore the sha1sum of the included zip is not the same with the one from %Source0. Please update to the current version (06-Jan-2007) or explain why should the previous version be accepted (and how can it be verified) before continuing the review. Indeed, new danish dictionaries available. Updated as http://people.redhat.com/caolanm/hunspell/hunspell-da-0.20070106-1.src.rpm http://people.redhat.com/caolanm/hunspell/hunspell-da.spec - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream , sha1sum 75bc7fbcbb9736cc4615bf19a5d74001e8c468ac da_DK.zip - the package builds in mock for devel/x86_64, generates a noarch (which is consistent with the fact that basically it includes only 3 text files) - the license GPL stated in the tag is the same as the one included in the upstream archive - there are only 2 files (word lists) + a short doc with instructions and license clearance, so no need for -doc and no .la, .pc, static files - no missing BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of other files/dirs - no duplicate files - permissions ok - %clean ok - macro use consistent - rpmlint outputsilent - code, not content - no need for -docs as the only doc is just the GPL license + usage instructions - nothing in %doc affects runtime - no need for .desktop file APPROVED 27540 (hunspell-da): Build on target fedora-development-extras succeeded. |