Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 487052
Summary: | Review Request: dc3dd - Patched version of GNU dd for use in computer forensics | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Adam Miller <maxamillion> |
Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora, pahan, rebus |
Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | dc3dd-7.1.614-8.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-03-09 22:43:28 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Adam Miller
2009-02-23 20:53:39 UTC
I had a look at this package. Here are my notes: ! Not a blocker but a suggestion: The recommended buildroot values are given in http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * Source0 is wrong. * rpmlint says: dc3dd.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/dc3dd-6.12.2/README You can probably correct this with sed 's|\r||' README > README.tmp touch -r README README.tmp mv -f README.tmp README in %prep. * Please remove the binary .gmo files in %prep. * It looks like the files NEWS, Options_Reference.txt, Sample_Commands.txt should go to %doc. * Each package must consistently use macros. Please make use of the %{name} macro. * Parallel make must be supported whenever possible. If it is not supported, this should be noted in the SPEC file as a comment. * The file lib/getdate.c is GPLv2+. That makes the license GPLv2+ and GPLv3+. ? What is the directory build-aux and the executable files in the root of the source tree for? Spec URL: http://maxamillion.fedorapeople.org/dc3dd.spec SRPM URL: http://maxamillion.fedorapeople.org/dc3dd-6.12.2-2.src.rpm I've cleaned up everything listed above. I fixed the licensing, removed the .gmo binaries, fixed source0 (sorry for that one, I based this spec off another spec of mine and mixed that up), added the doc items you listed, and fixed EOF encoding for the current and two added files to the package. Thank you very much for your feedback and I look forward to further review. Thanks for the update.
* To clean up the SPEC file you can use a for-loop like:
for file in README Sample_Commands.txt Options_Reference.txt; do
sed 's|\r||' $file > $file.tmp
touch -r $file $file.tmp
mv -f $file.tmp $file
done
* You probably missed this question I asked:
> ? What is the directory build-aux and the executable files in the root of the
source tree for?
The reason I asked was: If these files run tests to check whether the application is compiled properly, you will need to make a %check section and run these tests.
On the other hand, if these scripts are useful for people who want to use/develop dc3dd, you might want to put them in %{_datadir}/%{name} or inside %doc.
Spec URL: http://maxamillion.fedorapeople.org/dc3dd.spec SRPM URL: http://maxamillion.fedorapeople.org/dc3dd-6.12.2-3.src.rpm I applied the cleanup and I inspected the source of a number of the files in the build-aux directory and they appear to just be a cludge of python scripts that provide work arounds for different build environments and/or compilers that don't support certain things. Thank you again for your comments, looking forward to further review. So, those files are irrelevant. Then I think everything is fine now. You're welcome ---------------------------------------- This package (dc3dd) is APPROVED by oget ---------------------------------------- New Package CVS Request ======================= Package Name: dc3dd Short Description: Patched version of GNU dd for use in computer forensics Owners: maxamillion Branches: F-9 F-10 EL-4 EL-5 InitialCC: cvs done. dc3dd-6.12.2-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/dc3dd-6.12.2-3.fc9 dc3dd-6.12.2-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/dc3dd-6.12.2-3.fc10 dc3dd-6.12.2-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. dc3dd-6.12.2-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: dc3dd New Branches: epel7 Owners: maxamillion rebus Hello SCM team, plase can you add epel7 branch for the dc3dd package? Thank you Michal Ambroz Git done (by process-git-requests). dc3dd-7.1.614-8.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/dc3dd-7.1.614-8.el7 dc3dd-7.1.614-8.el7 has been pushed to the Fedora EPEL 7 stable repository. |