Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 514928
| Summary: | Review Request: rubygem-fastercsv - FasterCSV is CSV, but faster, smaller and cleaner | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Scheck <redhat-bugzilla> |
| Component: | Package Review | Assignee: | Jan Klepek <jan.klepek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, jan.klepek, mtasaka, notting, robert.scheck |
| Target Milestone: | --- | Flags: | jan.klepek:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.5.0-2.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-17 20:28:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robert Scheck
2009-07-31 14:50:32 UTC
1] use global instead of define
2] summary should not start with name of application/library and there is missing subject of that sentence.
better summary would be "Library for ..." and specifying what this library does.
does it parse csv files? or ... ?
3]
%if 0%{?rhel}%{?fedora} > 5
Requires: ruby(abi) = %{ruby_abiver}
%endif
it has to require ruby(abi) = 1.8 otherwise it conflict with ruby packaging guidelines
https://fedoraproject.org/wiki/Packaging:Ruby
4] multiple listed files
warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/fastercsv-1.5.0/AUTHORS
warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/fastercsv-1.5.0/CHANGELOG
warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/fastercsv-1.5.0/COPYING
warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/fastercsv-1.5.0/LICENSE
warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/fastercsv-1.5.0/README
Will correct 1/2/3/4, you're right. But given that 1 is a dumb Fedora decision, which makes no sense from the rpm-only point of view. Anything else I could correct as well? I don't want to provide a new *.src.rpm for every possible tiny future change - thank you. Some notes - LICENSE text says this is "GPLv2 or Ruby" - As gem file contains test/ directory, add %check section and execute some tests. By the way the comments 3] and 4] in comment 1 is blockers . Thank you both so far, I hopefully addressed all mentioned issues now: Spec URL: http://labs.linuxnetz.de/bugzilla/rubygem-fastercsv.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/rubygem-fastercsv-1.5.0-2.src.rpm 1] license: there is setup.rb which is LGPL reflect it in spec file with appropriate comment https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios *rpmlint ok *ruby guidelines ok *legible & english spec file *naming ok *directory ownage & files section ok *clean/install section & macros ok *utf-8 ok conclusion: License needs to be corrected, otherwise it looks ok (In reply to comment #5) > 1] > license: > there is setup.rb which is LGPL I don't think we should consider the license of setup.rb ( like that we usually does not consider the license of Makefile, configure ) Anyway "GPLv2 or Ruby" is stricter than LGPLv2 so this can be ignored anyway. As this is clarified now, anything else? approved Jan, thank you for the review. New Package CVS Request ======================= Package Name: rubygem-fastercsv Short Description: Faster, smaller and cleaner replacement to standard CSV library Owners: robert Branches: EL-5 F-10 F-11 InitialCC: cvs done. rubygem-fastercsv-1.5.0-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/rubygem-fastercsv-1.5.0-2.el5 rubygem-fastercsv-1.5.0-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-fastercsv-1.5.0-2.fc11 rubygem-fastercsv-1.5.0-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/rubygem-fastercsv-1.5.0-2.fc10 Package: rubygem-fastercsv-1.5.0-2.el5 Tag: dist-5E-epel-testing-candidate Status: complete Built by: robert Package: rubygem-fastercsv-1.5.0-2.fc10 Tag: dist-f10-updates-candidate Status: complete Built by: robert Package: rubygem-fastercsv-1.5.0-2.fc11 Tag: dist-f11-updates-candidate Status: complete Built by: robert Package: rubygem-fastercsv-1.5.0-2.fc12 Tag: dist-f12 Status: complete Built by: robert rubygem-fastercsv-1.5.0-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. rubygem-fastercsv-1.5.0-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. rubygem-fastercsv-1.5.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |