Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 570457
Summary: | Review Request: rubygem-right_rackspace - Interface classes for Rackspace | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michal Fojtik <mfojtik> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | derks, fedora-package-review, mfojtik, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review?
|
Target Release: | --- | ||
Hardware: | noarch | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-06-15 16:34:47 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 570111 |
Description
Michal Fojtik
2010-03-04 11:51:17 UTC
Both SPEC and SRPM produce a 404 File Not Found error. Please re-post your spec and source rpm. I'm sorry: Spec URL: http://mifo.sk/RPMS/rubygem-right_rackspace.spec SRPM URL: http://mifo.sk/RPMS/rubygem-right_rackspace-0.0.0.2-1.fc12.src.rpm Some notes: * (Build)Requires - The following Requires are all not needed. These are for development dependencies, not for runtime: ------------------------------------------------------------ Requires: rubygem(rubyforge) >= 2.0.3 Requires: rubygem(gemcutter) >= 0.3.0 Requires: rubygem(hoe) >= 2.5.0 ------------------------------------------------------------ - The correct dependency should be "rubygem(right_http_connection)" - As lib/right_rackspace.rb contains: ------------------------------------------------------------ 29 require 'json' ------------------------------------------------------------ This package should have "Requires: rubygem(json)" * %check - As this package contains test/ directory, please add %check section and execute some test program there. ping? ping again? Hi, I'm sorry, just working on it. Spec URL: http://mifo.sk/RPMS/rubygem-right_rackspace.spec SRPM URL: http://mifo.sk/RPMS/rubygem-right_rackspace-0.0.0.2-2.fc12.src.rpm (In reply to comment #3) > Some notes: > > * (Build)Requires > - The following Requires are all not needed. These are for development > dependencies, not for runtime: > ------------------------------------------------------------ > Requires: rubygem(rubyforge) >= 2.0.3 > Requires: rubygem(gemcutter) >= 0.3.0 > Requires: rubygem(hoe) >= 2.5.0 > ------------------------------------------------------------ > > - The correct dependency should be "rubygem(right_http_connection)" FIXED. > > - As lib/right_rackspace.rb contains: > ------------------------------------------------------------ > 29 require 'json' > ------------------------------------------------------------ > This package should have "Requires: rubygem(json)" FIXED. > > * %check > - As this package contains test/ directory, please add %check > section and execute some test program there. NACK. This is not possible, because you need to supply your RackSpace credentials into test file. Thanks! For -2: * rubygem(json) dependency - Well, ">= 1.2.0" dependency is really needed? Currently rubygem-json on Fedora rawhide is 1.1.9 (although the newest json is 1.4.1) * Permission ---------------------------------------------------------- rubygem-right_rackspace.noarch: E: script-without-shebang /usr/lib/ruby/gems/1.8/gems/right_rackspace-0.0.0.2/lib/support.rb ---------------------------------------------------------- - This script need not have executable permission. (In reply to comment #8) > For -2: > > * rubygem(json) dependency > - Well, ">= 1.2.0" dependency is really needed? Currently rubygem-json > on Fedora rawhide is 1.1.9 (although the newest json is 1.4.1) FIXED. Btw. I can't find 'json_pure' gem in bugzilla. Do you know if it's packaged ? I think this gem is used more often than 'json' gem. > * Permission > ---------------------------------------------------------- > rubygem-right_rackspace.noarch: E: script-without-shebang > /usr/lib/ruby/gems/1.8/gems/right_rackspace-0.0.0.2/lib/support.rb > ---------------------------------------------------------- > - This script need not have executable permission. FIXED. Spec URL: http://mifo.sk/RPMS/rubygem-right_rackspace.spec SRPM URL: http://mifo.sk/RPMS/rubygem-right_rackspace-0.0.0.2-3.fc12.src.rpm (In reply to comment #9) > SRPM URL: http://mifo.sk/RPMS/rubygem-right_rackspace-0.0.0.2-3.fc12.src.rpm - seems 404? By the way (In reply to comment #9) > Btw. I can't find 'json_pure' gem in bugzilla. Do you know if it's packaged ? I > think this gem is used more often than 'json' gem. - json gem is not in Fedora currently. By the way while I am not the maintainer of json (json on Fedora is maintained by laxathom), as far as I compared json with json_pure, json has some additional C extension modules compared to json_pure and all files in json_pure are also included in json. So it seems that json_pure is not needed if json is in the distribution. Are there any reason why json_pure is preferred? ... Of course I meant "json_pure is not in Fedora currently", sorry. ping? ping again? Again ping? I will close this bug as NOTABUG if no response is received from the reporter within ONE WEEK. Once closing. If someone wants to import this package into Fedora, please file a new review request and mark this one as a duplicate of the new one, thank you! |