Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 570457 - Review Request: rubygem-right_rackspace - Interface classes for Rackspace
Summary: Review Request: rubygem-right_rackspace - Interface classes for Rackspace
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: noarch
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 570111
TreeView+ depends on / blocked
 
Reported: 2010-03-04 11:51 UTC by Michal Fojtik
Modified: 2010-06-15 16:34 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-06-15 16:34:47 UTC
Type: ---
Embargoed:
mtasaka: fedora-review?

Attachments (Terms of Use)

Description Michal Fojtik 2010-03-04 11:51:17 UTC 
Spec URL: http://mifo.sk/rubygem-right_rackspace.spec
SRPM URL: http://mifo.sk/rubygem-right_rackspace-0.0.0.2-1.fc12.src.rpm
Description: 
Provides full programmatic access to Rackspace. Use this to interact
with the Rackspace Cloud product.
Comment 1 BJ Dierkes 2010-03-17 04:32:06 UTC 
Both SPEC and SRPM produce a 404 File Not Found error.  Please re-post your spec and source rpm.
Comment 2 Michal Fojtik 2010-03-18 12:55:54 UTC 
I'm sorry:

Spec URL: http://mifo.sk/RPMS/rubygem-right_rackspace.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-right_rackspace-0.0.0.2-1.fc12.src.rpm
Comment 3 Mamoru TASAKA 2010-04-06 08:40:10 UTC 
Some notes:

* (Build)Requires
  - The following Requires are all not needed. These are for development
    dependencies, not for runtime:
------------------------------------------------------------
Requires: rubygem(rubyforge) >= 2.0.3
Requires: rubygem(gemcutter) >= 0.3.0
Requires: rubygem(hoe) >= 2.5.0
------------------------------------------------------------

  - The correct dependency should be "rubygem(right_http_connection)"

  - As lib/right_rackspace.rb contains:
------------------------------------------------------------
    29  require 'json'
------------------------------------------------------------
    This package should have "Requires: rubygem(json)"

* %check
  - As this package contains test/ directory, please add %check
    section and execute some test program there.
Comment 4 Mamoru TASAKA 2010-04-16 17:14:17 UTC 
ping?
Comment 5 Mamoru TASAKA 2010-04-23 16:18:41 UTC 
ping again?
Comment 6 Michal Fojtik 2010-04-26 07:42:40 UTC 
Hi,

I'm sorry, just working on it.
Comment 7 Michal Fojtik 2010-04-26 07:49:51 UTC 
Spec URL: http://mifo.sk/RPMS/rubygem-right_rackspace.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-right_rackspace-0.0.0.2-2.fc12.src.rpm 

(In reply to comment #3)
> Some notes:
> 
> * (Build)Requires
>   - The following Requires are all not needed. These are for development
>     dependencies, not for runtime:
> ------------------------------------------------------------
> Requires: rubygem(rubyforge) >= 2.0.3
> Requires: rubygem(gemcutter) >= 0.3.0
> Requires: rubygem(hoe) >= 2.5.0
> ------------------------------------------------------------
> 
>   - The correct dependency should be "rubygem(right_http_connection)"

FIXED.

> 
>   - As lib/right_rackspace.rb contains:
> ------------------------------------------------------------
>     29  require 'json'
> ------------------------------------------------------------
>     This package should have "Requires: rubygem(json)"

FIXED.

> 
> * %check
>   - As this package contains test/ directory, please add %check
>     section and execute some test program there.    

NACK.
This is not possible, because you need to supply your RackSpace credentials into test file.


Thanks!
Comment 8 Mamoru TASAKA 2010-04-26 18:04:48 UTC 
For -2:

* rubygem(json) dependency
  - Well, ">= 1.2.0" dependency is really needed? Currently rubygem-json
    on Fedora rawhide is 1.1.9 (although the newest json is 1.4.1)

* Permission
----------------------------------------------------------
rubygem-right_rackspace.noarch: E: script-without-shebang /usr/lib/ruby/gems/1.8/gems/right_rackspace-0.0.0.2/lib/support.rb
----------------------------------------------------------
  - This script need not have executable permission.
Comment 9 Michal Fojtik 2010-04-30 07:48:26 UTC 
(In reply to comment #8)
> For -2:
> 
> * rubygem(json) dependency
>   - Well, ">= 1.2.0" dependency is really needed? Currently rubygem-json
>     on Fedora rawhide is 1.1.9 (although the newest json is 1.4.1)

FIXED.

Btw. I can't find 'json_pure' gem in bugzilla. Do you know if it's packaged ? I think this gem is used more often than 'json' gem.

> * Permission
> ----------------------------------------------------------
> rubygem-right_rackspace.noarch: E: script-without-shebang
> /usr/lib/ruby/gems/1.8/gems/right_rackspace-0.0.0.2/lib/support.rb
> ----------------------------------------------------------
>   - This script need not have executable permission.    

FIXED.

Spec URL: http://mifo.sk/RPMS/rubygem-right_rackspace.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-right_rackspace-0.0.0.2-3.fc12.src.rpm
Comment 10 Mamoru TASAKA 2010-04-30 18:18:30 UTC 
(In reply to comment #9)
> SRPM URL: http://mifo.sk/RPMS/rubygem-right_rackspace-0.0.0.2-3.fc12.src.rpm    
- seems 404?

By the way
(In reply to comment #9)
> Btw. I can't find 'json_pure' gem in bugzilla. Do you know if it's packaged ? I
> think this gem is used more often than 'json' gem.

- json gem is not in Fedora currently. 

  By the way while I am not the maintainer of json 
  (json on Fedora is maintained by laxathom), as far as I compared
  json with json_pure, json has some additional C extension modules
  compared to json_pure and all files in json_pure are also included
  in json. So it seems that json_pure is not needed if json is in
  the distribution. Are there any reason why json_pure is preferred?
Comment 11 Mamoru TASAKA 2010-04-30 19:04:26 UTC 
... Of course I meant "json_pure is not in Fedora currently", sorry.
Comment 12 Mamoru TASAKA 2010-05-12 15:35:29 UTC 
ping?
Comment 13 Mamoru TASAKA 2010-05-21 16:45:31 UTC 
ping again?
Comment 14 Mamoru TASAKA 2010-05-30 05:35:39 UTC 
Again ping?
Comment 15 Mamoru TASAKA 2010-06-06 16:58:05 UTC 
I will close this bug as NOTABUG if no response is received
from the reporter within ONE WEEK.
Comment 16 Mamoru TASAKA 2010-06-15 16:34:47 UTC 
Once closing.

If someone wants to import this package into Fedora, please file
a new review request and mark this one as a duplicate of the
new one, thank you!
Note You need to log in before you can comment on or make changes to this bug.