Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 752447 (plasma-mobile)
Summary: | Review Request: plasma-mobile - A Plasma Active mobile workspace | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jaroslav Reznik <jreznik> | ||||
Component: | Package Review | Assignee: | Rex Dieter <rdieter> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | kevin, notting, package-review, rdieter | ||||
Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2011-11-29 16:05:51 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 656997 | ||||||
Attachments: |
|
Description
Jaroslav Reznik
2011-11-09 14:45:47 UTC
A couple of concerns off the top of my head. 1. desktop-file-validate %check fails. (I'll attach a patch that fixes it for me on f16), upstreamed these fixes already to git.kde.org 2. %{_qt4_plugindir}/inputmethods/plasmainputcontextplugin.so will get multilib'd, so probably want to make -libs package for this item 3. file /usr/lib64/kde4/imports/org/kde/plasma/mobilecomponents is not owned by any package. can probably just recursively own that dir, instead of enumerating the items under it. Created attachment 532620 [details]
fix desktop-file-validate errors
Spec URL: http://rezza.hofyland.cz/fedora/packages/plasma-mobile/plasma-mobile.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/plasma-mobile/plasma-mobile-0.2-2.fc15.src.rpm (In reply to comment #1) > A couple of concerns off the top of my head. > > 1. desktop-file-validate %check fails. (I'll attach a patch that fixes it for > me on f16), upstreamed these fixes already to git.kde.org Ah, I had these patches locally, forgot to add to SPEC/SRPM - in your patch, there's still one error, I'll take a look if I can upstream it > 2. %{_qt4_plugindir}/inputmethods/plasmainputcontextplugin.so > will get multilib'd, so probably want to make -libs package for this item Ok, added -libs. > 3. file /usr/lib64/kde4/imports/org/kde/plasma/mobilecomponents is not owned > by any package. can probably just recursively own that dir, instead of > enumerating the items under it. Fixed. Looking good. naming: ok sources: ok md5sum *.bz2 ec5560f243a861ea3eedcfc4103cf6d6 plasma-mobile-0.2.tar.bz2 licensing: ok macros: ok scriptlets: ok APPROVED. New Package SCM Request ======================= Package Name: plasma-mobile Short Description: A Plasma Active mobile workspace Owners: jreznik rdieter kkofler than rnovacek ltinkl Branches: f16 InitialCC: Git done (by process-git-requests). |