Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 752447 (plasma-mobile) - Review Request: plasma-mobile - A Plasma Active mobile workspace
Summary: Review Request: plasma-mobile - A Plasma Active mobile workspace
Keywords:
Status: CLOSED RAWHIDE
Alias: plasma-mobile
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-11-09 14:45 UTC by Jaroslav Reznik
Modified: 2011-11-29 16:05 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-29 16:05:51 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
fix desktop-file-validate errors (1.54 KB, patch)
2011-11-09 17:01 UTC, Rex Dieter 		no flags Details | Diff
View All

Description Jaroslav Reznik 2011-11-09 14:45:47 UTC 
Spec URL: http://rezza.hofyland.cz/fedora/packages/plasma-mobile/plasma-mobile.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/plasma-mobile/plasma-mobile-0.2-1.fc15.src.rpm
Description: A touch enabled Plasma Active workspace aiming on different
(not only) mobile devices.
Comment 1 Rex Dieter 2011-11-09 17:00:17 UTC 
A couple of concerns off the top of my head.

1.  desktop-file-validate %check fails. (I'll attach a patch that fixes it for me on f16), upstreamed these fixes already to git.kde.org

2.  %{_qt4_plugindir}/inputmethods/plasmainputcontextplugin.so
will get multilib'd, so probably want to make -libs package for this item

3.  file /usr/lib64/kde4/imports/org/kde/plasma/mobilecomponents is not owned by any package.  can probably just recursively own that dir, instead of enumerating the items under it.
Comment 2 Rex Dieter 2011-11-09 17:01:01 UTC 
Created attachment 532620 [details]
fix desktop-file-validate errors
Comment 3 Jaroslav Reznik 2011-11-10 13:47:32 UTC 
Spec URL:
http://rezza.hofyland.cz/fedora/packages/plasma-mobile/plasma-mobile.spec
SRPM URL:
http://rezza.hofyland.cz/fedora/packages/plasma-mobile/plasma-mobile-0.2-2.fc15.src.rpm

(In reply to comment #1)
> A couple of concerns off the top of my head.
> 
> 1.  desktop-file-validate %check fails. (I'll attach a patch that fixes it for
> me on f16), upstreamed these fixes already to git.kde.org

Ah, I had these patches locally, forgot to add to SPEC/SRPM - in your patch, there's still one error, I'll take a look if I can upstream it

> 2.  %{_qt4_plugindir}/inputmethods/plasmainputcontextplugin.so
> will get multilib'd, so probably want to make -libs package for this item

Ok, added -libs.

> 3.  file /usr/lib64/kde4/imports/org/kde/plasma/mobilecomponents is not owned
> by any package.  can probably just recursively own that dir, instead of
> enumerating the items under it.

Fixed.
Comment 4 Rex Dieter 2011-11-11 16:35:50 UTC 
Looking good.

naming: ok

sources: ok
md5sum *.bz2
ec5560f243a861ea3eedcfc4103cf6d6  plasma-mobile-0.2.tar.bz2

licensing: ok

macros: ok

scriptlets: ok


APPROVED.
Comment 5 Jaroslav Reznik 2011-11-16 10:59:14 UTC 
New Package SCM Request
=======================
Package Name: plasma-mobile
Short Description: A Plasma Active mobile workspace
Owners: jreznik rdieter kkofler than rnovacek ltinkl
Branches: f16
InitialCC:
Comment 6 Gwyn Ciesla 2011-11-16 12:09:26 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.