Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 785457 (Horde_Text_Flowed)
Summary: | Review Request: php-horde-Horde-Text-Flowed - Horde API for flowed text as per RFC 3676 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nick Bebout <nb> | ||||||
Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | CC: | fedora, notting, package-review, shawn | ||||||
Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2013-02-28 06:59:30 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | 785424, 785439 | ||||||||
Bug Blocks: | 785460, 895622, 908389 | ||||||||
Attachments: |
|
Description
Nick Bebout
2012-01-29 01:58:46 UTC
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Text-Flowed.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Text-Flowed-1.0.1-1.fc16.src.rpm I will review this package *** [MUST] Please check the license. I see LGPLv2 (from source) but I do not see LGPLv2+ (from spec), i.e. "LGPLv2 or later", mentioned anywhere. *** [SHOULD] It would help readability to group your Build* and Requires* statements together instead of mixing them with each other and your Provides and Conflicts statements *** [MUST] Your BuildRequires should be BuildRequires: php-pear(PEAR) >= 1.7.0 instead of BuildRequires: php-pear >= 1:1.4.9-1.2 (this would match what you have in bug 785606 and satisfy this package's package.xml dependency) *** [MUST] Add "Requires: php-common >= 5.2.0" to satisfy package.xml requirement *** [SHOULD] phpci results: For completeness (and to prevent any future packaging issues due to PHP package changes) you may wish to require the virtual package "php-pcre". *** [SHOULD] package.xml lists a dependency of Horde_Util >= 1.0.0 and < 2.0.0. You already have a require for < 2.0.0. I'm not sure if it's required, but I like to be verbose so I would suggest adding the >= 1.0.0 require even though it appears all packages in Fedora satisfy this requirement already. *** [SHOULD] Please consider adding a note for optional dependencies "Horde_Test" and "PHPUnit (perhaps in %description for end users) and note what they are needed for. *** [SHOULD; see https://bugzilla.redhat.com/show_bug.cgi?id=817303#c5] About [ -f package2.xml ] || mv package.xml package2.xml mv package2.xml %{pear_name}-%{version}/%{name}.xml This is a old hack (yes it works) to ensure than package v2 is used. I often use # package.xml is version 2.0 mv package.xml %{pear_name}-%{version}/%{name}.xml This is not an issue, but makes the spec simpler to read. *** [MUST] In %files, use %{pear_name} where you can. *** [SHOULD] It may be beneficial to use "%global pear_channel pear.horde.org" and then use "%{pear_channel}" where you can. Please update to 2.0.1 Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Text-Flowed.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Text-Flowed-2.0.1-2.fc17.src.rpm Created attachment 694002 [details]
phpci.log
Created attachment 694003 [details]
php-horde-Horde-Text-Flowed-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 785457
[!]: License field in the package spec file matches the actual license. LGPLv2 (not LGPLv2+) [!]: Requires correct, justified where necessary. php-cre php-pear(PEAR) >= 1.7.0 To be consistent, also BuildRequires: php-common >= 5.3.0 BuildRequires: php-pear(PEAR) >= 1.7.0 Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Text-Flowed.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Text-Flowed-2.0.1-3.fc17.src.rpm < License: LGPLv2+ --- > License: LGPLv2 [x]: License field in the package spec file matches the actual license. > Requires: php-cre > Requires: php-pear(PEAR) >= 1.7.0 [x]: Requires correct, justified where necessary. > BuildRequires: php-pear(PEAR) >= 1.7.0 > BuildRequires: php-common >= 5.3.0 No blocker === APPROVED === New Package SCM Request ======================= Package Name: php-horde-Horde-Text-Flowed Short Description: Horde API for flowed text as per RFC 3676 Owners: nb remi Branches: el6 f18 InitialCC: Git done (by process-git-requests). php-horde-Horde-Alarm-2.0.3-3.fc18, php-horde-Horde-Image-2.0.3-3.fc18, php-horde-Horde-Lock-2.0.1-3.fc18, php-horde-Horde-Text-Flowed-2.0.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Text-Flowed-2.0.1-3.fc18,php-horde-Horde-Lock-2.0.1-3.fc18,php-horde-Horde-Image-2.0.3-3.fc18,php-horde-Horde-Alarm-2.0.3-3.fc18 php-horde-Horde-Image-2.0.3-3.el6, php-horde-Horde-Alarm-2.0.3-3.el6, php-horde-Horde-Lock-2.0.1-3.el6, php-horde-Horde-Argv-2.0.4-4.el6, php-horde-Horde-Serialize-2.0.1-3.el6, php-horde-Horde-Text-Flowed-2.0.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Text-Flowed-2.0.1-3.el6,php-horde-Horde-Serialize-2.0.1-3.el6,php-horde-Horde-Argv-2.0.4-4.el6,php-horde-Horde-Lock-2.0.1-3.el6,php-horde-Horde-Image-2.0.3-3.el6,php-horde-Horde-Alarm-2.0.3-3.el6 Package php-horde-Horde-Alarm-2.0.3-3.fc18, php-horde-Horde-Image-2.0.3-3.fc18, php-horde-Horde-Lock-2.0.1-3.fc18, php-horde-Horde-Text-Flowed-2.0.1-3.fc18, php-horde-Horde-Argv-2.0.4-4.fc18, php-horde-Horde-Serialize-2.0.1-3.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing php-horde-Horde-Alarm-2.0.3-3.fc18 php-horde-Horde-Image-2.0.3-3.fc18 php-horde-Horde-Lock-2.0.1-3.fc18 php-horde-Horde-Text-Flowed-2.0.1-3.fc18 php-horde-Horde-Argv-2.0.4-4.fc18 php-horde-Horde-Serialize-2.0.1-3.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-2619/php-horde-Horde-Argv-2.0.4-4.fc18,php-horde-Horde-Serialize-2.0.1-3.fc18,php-horde-Horde-Text-Flowed-2.0.1-3.fc18,php-horde-Horde-Lock-2.0.1-3.fc18,php-horde-Horde-Image-2.0.3-3.fc18,php-horde-Horde-Alarm-2.0.3-3.fc18 then log in and leave karma (feedback). php-horde-Horde-Alarm-2.0.3-3.fc18, php-horde-Horde-Image-2.0.3-3.fc18, php-horde-Horde-Lock-2.0.1-3.fc18, php-horde-Horde-Argv-2.0.4-4.fc18, php-horde-Horde-Serialize-2.0.1-3.fc18, php-horde-Horde-Text-Flowed-2.0.1-4.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. php-horde-Horde-Image-2.0.3-3.el6, php-horde-Horde-Alarm-2.0.3-3.el6, php-horde-Horde-Lock-2.0.1-3.el6, php-horde-Horde-Argv-2.0.4-4.el6, php-horde-Horde-Serialize-2.0.1-3.el6, php-horde-Horde-Text-Flowed-2.0.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |