Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== Generic ====
[ ]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[!]: MUST Buildroot is not present
     Note: Buildroot is not needed unless packager plans to package for EPEL5
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[ ]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: defattr(....) present in %files section. This is OK if packaging
     for EPEL5. Otherwise not needed
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[ ]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[ ]: MUST License field in the package spec file matches the actual license.
[ ]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generates any conflict.
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[ ]: MUST Package installs properly.
[ ]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint php-channel-horde-1.0-1.noarch.rpm

php-channel-horde.noarch: W: invalid-license N/A
php-channel-horde.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


rpmlint php-channel-horde-1.0-1.src.rpm

php-channel-horde.src: W: invalid-license N/A
php-channel-horde.src:18: W: unversioned-explicit-provides php-channel(pear.horde.org)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/media/projects/salt-repo/785424/channel.xml :
  MD5SUM this package     : 04d1f0382ea1aca36b46b95612ef1091
  MD5SUM upstream package : 04d1f0382ea1aca36b46b95612ef1091

[ ]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[ ]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[ ]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[!]: SHOULD Dist tag is present.
[ ]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[ ]: SHOULD Package functions as described.
[ ]: SHOULD Package does not include license text files separate from
     upstream.
[ ]: SHOULD Scriptlets must be sane, if used.
[x]: SHOULD SourceX is a working URL.
[ ]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[ ]: SHOULD %check is present and all tests pass.
[ ]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[!]: SHOULD Spec use %global instead of %define.
     Note: %define peardir %(pear config-get php_dir 2> /dev/null || echo
     %{_datadir}/pear) %define pear_xmldir /var/lib/pear

Issues:
[!]: MUST Buildroot is not present
     Note: Buildroot is not needed unless packager plans to package for EPEL5
[!]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: defattr(....) present in %files section. This is OK if packaging
     for EPEL5. Otherwise not needed
[!]: MUST Rpmlint output is silent.

rpmlint php-channel-horde-1.0-1.noarch.rpm

php-channel-horde.noarch: W: invalid-license N/A
php-channel-horde.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


rpmlint php-channel-horde-1.0-1.src.rpm

php-channel-horde.src: W: invalid-license N/A
php-channel-horde.src:18: W: unversioned-explicit-provides php-channel(pear.horde.org)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Looks like just a few minor fixes.

Updated.
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-channel-horde.spec
SRPM URL:
http://nb.fedorapeople.org/horde-reviews/php-channel-horde-1.0-1.fc16.src.rpm

Buildroot removed
%defattr removed
License fixed
No documentation warning is ok
unversioned-explicit-provides is done per php pear channel packaging guidelines
I also added a disttag

[nb@desktop SPECS]$ rpmlint php-channel-horde.spec 
php-channel-horde.spec:17: W: unversioned-explicit-provides php-channel(pear.horde.org)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
[nb@desktop SRPMS]$ rpmlint php-channel-horde-1.0-1.fc16.src.rpm 
php-channel-horde.src:17: W: unversioned-explicit-provides php-channel(pear.horde.org)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[nb@desktop noarch]$ rpmlint php-channel-horde-1.0-1.fc16.noarch.rpm 
php-channel-horde.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Also, please assign the bug to yourself and set fedora-review to ? and status to ASSIGNED when starting a review.

Oops, meant to do that! :)

I'm approving this with one caveat.

[!]: SHOULD Spec use %global instead of %define.
     Note: %define peardir %(pear config-get php_dir 2> /dev/null || echo
     %{_datadir}/pear) %define pear_xmldir /var/lib/pear

Might be good to change that definition.

You don't need to define pear_xmldir which is provided by pear and is define to /usr/share/pear/.pkgxml (else the /var/lib/pear dir will not be owned)

You don't need to define peardir, as you don't use it

Missing 
Requires(post): %{__pear}
Requires(postun): %{__pear}

From Guidelines, min pear version is 1:1.4.9-1.2 (which provides the needed macro and install/uninstall registration to work)

Please also fill the "Blocks" to create a good dependency tree for all the php-horde-* packages

Everything should be fixed now and I'll add the other reviews to Blocks:

New Package SCM Request
=======================
Package Name: php-channel-horde
Short Description: 
Owners: nb tibbs
Branches: f16 el6
InitialCC:

Please fill in description.

New Package SCM Request
=======================
Package Name: php-channel-horde
Short Description: Adds pear.horde.org channel to PEAR
Owners: nb tibbs
Branches: f16 el6
InitialCC:

Git done (by process-git-requests).

php-channel-horde-1.0-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/php-channel-horde-1.0-1.fc16

php-channel-horde-1.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-channel-horde-1.0-1.el6

php-channel-horde-1.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository.

php-channel-horde-1.0-1.fc16 has been pushed to the Fedora 16 stable repository.

php-channel-horde-1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.