Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 785442 (Horde_Date) - Review Request: php-horde-Horde-Date - Horde Date package
Summary: Review Request: php-horde-Horde-Date - Horde Date package
Keywords:
Status: CLOSED NEXTRELEASE
Alias: Horde_Date
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: horde-channel Horde_Translation Horde_Exception Horde_Nls
Blocks: Horde_Alarm 785463 Horde_Db Horde_Icalendar Horde_SyncMl
TreeView+ depends on / blocked
 
Reported: 2012-01-29 00:06 UTC by Nick Bebout
Modified: 2013-03-26 13:04 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-18 23:41:06 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
php-horde-Horde-Date.spec (2.42 KB, text/plain)
2012-06-30 05:27 UTC, Remi Collet 		no flags Details
php-horde-Horde-Date-review.txt (6.98 KB, text/plain)
2012-07-17 15:02 UTC, Remi Collet 		no flags Details
View All

Description Nick Bebout 2012-01-29 00:06:16 UTC 
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Date.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Date-1.0.9-1.fc16.src.rpm
Description: Package for creating and manipulating dates.
Comment 1 Remi Collet 2012-02-19 08:02:19 UTC 
Please
- handle locales
- remove "Conflicts"
- you can remove "Requires" of channel and Horde_Exception (implicitly required by Horde_Nls)
Comment 2 Remi Collet 2012-05-28 06:23:05 UTC 
Any news on this package ?
Comment 3 Nick Bebout 2012-06-14 20:41:04 UTC 
Sorry for the delay:

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Date.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Date-1.0.10-1.fc16.src.rpm
Comment 4 Remi Collet 2012-06-30 05:27:00 UTC 
Created attachment 595410 [details]
php-horde-Horde-Date.spec

Generated by fedora-review 0.1.3
Comment 5 Remi Collet 2012-06-30 05:32:54 UTC 
You could consider adding the implicit requires.
* Horde_Exception and Horde_Util (for Horde_String)
* php-common >= 5.2.0

You could also consider adding the "optional" dependency on Horde_Icalendar, when it will be approved, if this don't create a circular dependency nightmare.

In Provides and %file, please use %{pear_name} where possible

A %{pear_channel} could be usefull (pear.horde.org)

Only blocker is (as you have drop other EL-5 stuff) 
MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
Comment 6 Remi Collet 2012-06-30 07:20:38 UTC 
Please also update to 1.0.11
Comment 7 Nick Bebout 2012-07-13 01:50:12 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Date.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Date-1.0.11-1.fc16.src.rpm
Comment 8 Remi Collet 2012-07-17 15:02:39 UTC 
Created attachment 598669 [details]
php-horde-Horde-Date-review.txt

Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09
Comment 9 Remi Collet 2012-07-17 15:05:38 UTC 
No blocker.

Please consider updating BR php-pear to version 1.7.0 (from package.xml).

Others implicitly requires could be add, but at your choice.


== APPROVED ==
Comment 10 Nick Bebout 2012-07-17 22:40:57 UTC 
New Package SCM Request
=======================
Package Name: php-horde-Horde-Date
Short Description: Package for creating and manipulating dates in Horde
Owners: nb
Branches: el6 f16 f17
InitialCC:
Comment 11 Gwyn Ciesla 2012-07-18 03:14:58 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.