Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 785436 (Horde_Exception) - Review Request: php-horde-Horde-Exception - Horde Exception Handler
Summary: Review Request: php-horde-Horde-Exception - Horde Exception Handler
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: Horde_Exception
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: horde-channel Horde_Translation
Blocks: Horde_Url Horde_Date Horde_Alarm Horde_Argv Horde_Auth Horde_Browser Horde_Cache Horde_Token Horde_Mail Horde_Support Horde_Mime 785463 Horde_Group horde-http Horde_Image Horde_Db 785473 Horde_Prefs horde-lock Horde_Serialize Horde_Icalendar horde-text-diff Horde_Controller Horde_Compress Horde_Data Horde_Rpc Horde_Ldap 894563 Horde_Editor Horde_Xml_Element Horde_Text_Diff Horde_Tree Horde_Vfs Horde_History
TreeView+ depends on / blocked
 
Reported: 2012-01-28 23:38 UTC by Nick Bebout
Modified: 2013-03-23 15:44 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-21 23:49:28 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Nick Bebout 2012-01-28 23:38:15 UTC 
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Exception.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Exception-1.0.8-1.fc16.src.rpm
Description: This class provides the default exception handlers for the Horde Application Framework.
Comment 1 Remi Collet 2012-01-29 16:38:43 UTC 
According to upstream (package.xml), this requires:
BuildRequires: php-pear(PEAR) >= 1.7.0
Requires: php-common >= 5.2.0

Avoir conflicts
pear-pear(pear.horde.org/Horde_Translation) >= 1.0.0
pear-pear(pear.horde.org/Horde_Translation) < 2.0.0

%file
%{pear_xmldir}/%{name}.xml
%{pear_phpdir}/Horde/Exception
%{pear_phpdir}/Horde/Exception.php
%{pear_datadir}/Horde_Exception
%{pear_testdir}/Horde_Exception
Comment 2 Nick Bebout 2012-01-29 21:23:58 UTC 
Updated.
Comment 3 Remi Collet 2012-01-30 07:20:44 UTC 
License is LGPLv2+

This package must handle locales properly,
http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
Comment 4 Nick Bebout 2012-01-30 16:04:33 UTC 
Updated
Comment 5 Remi Collet 2012-01-30 17:54:30 UTC 
We need to discuss about locales in this package (and probably the other php-horde-*)

With current spec
warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/ar/LC_MESSAGES/Horde_Exception.mo
warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/bg/LC_MESSAGES/Horde_Exception.mo
warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/bs/LC_MESSAGES/Horde_Exception.mo
warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/ca/LC_MESSAGES/Horde_Exception.mo
warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/cs/LC_MESSAGES/Horde_Exception.mo
warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/da/LC_MESSAGES/Horde_Exception.mo
...

%dir %{pear_datadir}/Horde_Exception should be enough, but it also contains .pot and .po files.

I really don't think this are needed, as Horde_Translation use "gettext" by default (but I don't know if others backend are available in Horde stack, which requires .po)

Could you please ask upstream about this ?

(better solution to exclude files, is to delete lines in the package.xml, to keep "pear list-files" report consistent)
Comment 6 Nick Bebout 2012-02-10 01:19:22 UTC 
I think this one is ready to review.
Comment 7 Nick Bebout 2012-02-10 01:19:40 UTC 
I made the changes you suggested via email.
Comment 8 Remi Collet 2012-02-10 16:21:00 UTC 
it seems you have forgotten to update/upload the new spec/srpm (last is January 30)
Comment 9 Nick Bebout 2012-02-15 20:58:27 UTC 
I've uploaded it now.
Comment 10 Remi Collet 2012-02-18 13:58:11 UTC 
This one is ok (Package must own all directories that it creates.)


You could removed 
Requires:       php-channel(pear.horde.org)
As this package is already required by php-pear(pear.horde.org/Horde_Translation)


This package is APPROVED
(must wait for Horde_Translation before importing to repo)
Comment 11 Nick Bebout 2012-02-18 15:13:00 UTC 
New Package SCM Request
=======================
Package Name:  php-horde-Horde-Exception
Short Description: Provides the default exception handlers for the Horde
Application Framework
Owners: nb
Branches: f16 f17 el6
InitialCC:
Comment 12 Nick Bebout 2012-02-18 15:14:27 UTC 
New Package SCM Request
=======================
Package Name:  php-horde-Horde-Exception
Short Description: Provides the default exception handlers for the Horde Application Framework
Owners: nb
Branches: f16 f17 el6
InitialCC:
Comment 13 Gwyn Ciesla 2012-02-19 20:38:03 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.