Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 785494 (Horde_Compress) - Review Request: php-horde-Horde-Compress - Horde Compression API
Summary: Review Request: php-horde-Horde-Compress - Horde Compression API
Keywords:
Status: CLOSED ERRATA
Alias: Horde_Compress
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: horde-channel Horde_Translation Horde_Exception Horde_Util Horde_Stream_Filter
Blocks: Horde_Mime_Viewer Horde_Core
TreeView+ depends on / blocked
 
Reported: 2012-01-29 04:28 UTC by Nick Bebout
Modified: 2013-03-29 21:30 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-29 01:38:35 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
phpci.log (13.98 KB, text/plain)
2013-02-08 17:44 UTC, Remi Collet 		no flags Details
php-horde-Horde-Compress-review.txt (8.00 KB, text/plain)
2013-02-08 17:45 UTC, Remi Collet 		no flags Details
View All

Description Nick Bebout 2012-01-29 04:28:30 UTC 
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress-1.0.6-1.fc16.src.rpm
Description: An API for various compression techniques.
Comment 1 Shawn Iwinski 2012-06-20 03:09:40 UTC 
I am not an official package reviewer, but here are some comments I have for this package:



*** It would help readability to group your Build* and Requires* statements together instead of mixing them with each other and your Provides and Conflicts statements



*** Your BuildRequires should be
BuildRequires:  php-pear(PEAR) >= 1.7.0
instead of
BuildRequires:  php-pear >= 1:1.4.9-1.2
(this would match what you have in bug 785606 and satisfy this package's package.xml dependency)



*** Your Provides statement should be
Provides:	php-pear(pear.horde.org/%{pear_name}) = %{version}
instead of
Provides:	php-pear(%{pear_name}) = %{version}



*** phpci results: For completeness (and to prevent any future packaging issues due to PHP package changes), you may wish to require the virtual provides "php-date", "php-pcre" and "php-zlib".



*** All locale %files should be tagged with "%lang(xx)".  rpmlint warnings:
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ar/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/bg/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/bs/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ca/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/cs/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/da/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/de/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/el/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/en/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/es/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/et/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/eu/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/fa/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/fi/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/fr/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/gl/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/he/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/hr/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/hu/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/id/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/is/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/it/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ja/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/km/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ko/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/lt/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/lv/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/mk/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/nb/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/nl/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/nn/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/pl/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/pt/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/pt_BR/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ro/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ru/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/sk/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/sl/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/sv/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/tr/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/uk/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/zh_CN/LC_MESSAGES/Horde_Compress.mo
php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/zh_TW/LC_MESSAGES/Horde_Compress.mo



*** Do you plan on building for EPEL 5?
- If not, please remove "rm -rf $RPM_BUILD_ROOT" from the %install section (see http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag).
- If you do, there are several staements that need to be added.



*** Up to you, but package.xml lists the optional package php-pear(pear.horde.org/Horde_Stream_Filter) if you choose to require (if you do choose to require this package, please update this ticket's "Depends On")
Comment 2 Nick Bebout 2012-06-21 01:38:25 UTC 
I believe I have fixed those issues:

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress-1.0.7-1.fc16.src.rpm
Comment 3 Shawn Iwinski 2012-06-23 12:57:46 UTC 
(In reply to comment #2)

Almost ready for official review. Please change

Requires:	php-pear(pear.horde.org/Horde_Stream_Filter)

to

Requires:	php-pear(pear.horde.org/Horde_Stream_Filter) < 2.0.0

per package.xml requirements
Comment 4 Shawn Iwinski 2012-06-23 13:09:44 UTC 
(In reply to comment #3)

Also, please add:

Requires: php-common >= 5.2.0
Comment 5 Nick Bebout 2012-06-25 15:15:52 UTC 
I believe I have fixed those issues:

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress-1.0.7-2.fc16.src.rpm
Comment 6 Nick Bebout 2012-07-19 16:50:59 UTC 
I believe all of the normal blockers for the php-horde-Horde-* packages are fixed with this package.
Comment 7 Nick Bebout 2013-02-06 21:22:15 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress-2.0.3-2.fc17.src.rpm
Comment 8 Remi Collet 2013-02-08 17:44:46 UTC 
Created attachment 695182 [details]
phpci.log
Comment 9 Remi Collet 2013-02-08 17:45:16 UTC 
Created attachment 695183 [details]
php-horde-Horde-Compress-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 785494
Comment 10 Remi Collet 2013-02-08 17:47:32 UTC 
[!]: Requires correct, justified where necessary.
	use php-common instead of php(language) for now
	except if you plan to differ EPEL-6 import until 6.4 release

[!]: %check is present and all tests pass.

I think I have send you, by mail, the correct script for %check which allow to run test (when locale used), even in mock.

See : https://github.com/remicollet/remirepo/commit/fbcd7356809f945fb6c9e163cecd98bd68139b1c
Comment 11 Nick Bebout 2013-03-20 20:53:04 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress-2.0.3-3.fc17.src.rpm
Comment 12 Remi Collet 2013-03-21 16:17:34 UTC 
[x]: %check is present and all tests pass.

== APPROVED ==
Comment 13 Nick Bebout 2013-03-21 23:10:30 UTC 
New Package SCM Request
=======================
Package Name: php-horde-Horde-Compress
Short Description: An API for various compression techniques
Owners: nb remi
Branches: el6 f18 f19
InitialCC:
Comment 14 Gwyn Ciesla 2013-03-22 12:47:35 UTC 
Git done (by process-git-requests).
Comment 15 Fedora Update System 2013-03-23 22:00:50 UTC 
php-horde-Horde-Compress-2.0.3-3.fc18,php-horde-Horde-Controller-2.0.1-3.fc18,php-horde-Horde-Mail-2.0.4-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-horde-Horde-Compress-2.0.3-3.fc18,php-horde-Horde-Controller-2.0.1-3.fc18,php-horde-Horde-Mail-2.0.4-1.fc18
Comment 16 Fedora Update System 2013-03-23 22:01:54 UTC 
php-horde-Horde-Mail-2.0.4-1.el6,php-horde-Horde-Template-2.0.1-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-horde-Horde-Mail-2.0.4-1.el6,php-horde-Horde-Template-2.0.1-3.el6
Comment 17 Fedora Update System 2013-03-24 17:58:53 UTC 
Package php-horde-Horde-Mail-2.0.4-1.el6, php-horde-Horde-Template-2.0.1-3.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing php-horde-Horde-Mail-2.0.4-1.el6 php-horde-Horde-Template-2.0.1-3.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-0785/php-horde-Horde-Mail-2.0.4-1.el6,php-horde-Horde-Template-2.0.1-3.el6
then log in and leave karma (feedback).
Comment 18 Fedora Update System 2013-03-29 01:38:38 UTC 
php-horde-Horde-Compress-2.0.3-3.fc18, php-horde-Horde-Controller-2.0.1-3.fc18, php-horde-Horde-Mail-2.0.4-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 19 Fedora Update System 2013-03-29 21:30:08 UTC 
php-horde-Horde-Mail-2.0.4-1.el6, php-horde-Horde-Template-2.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.