Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 785451 (Horde_Token) - Review Request: php-horde-Horde-Token - Horde Token API
Summary: Review Request: php-horde-Horde-Token - Horde Token API
Keywords:
Status: CLOSED ERRATA
Alias: Horde_Token
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: horde-channel Horde_Translation Horde_Exception Horde_Url Horde_Util
Blocks: 785463 Horde_Core
TreeView+ depends on / blocked
 
Reported: 2012-01-29 01:37 UTC by Nick Bebout
Modified: 2013-03-28 18:39 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-27 20:29:28 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Nick Bebout 2012-01-29 01:37:42 UTC 
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token-1.1.4-1.fc16.src.rpm
Description: The Horde_Token:: class provides a common abstracted interface into the various token generation mediums. It also includes all of the functions for retrieving, storing, and checking tokens.
Comment 1 Nick Bebout 2012-06-21 21:12:55 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token-1.1.7-1.fc16.src.rpm
Comment 2 Shawn Iwinski 2012-07-04 23:43:51 UTC 
I will review this package
Comment 3 Shawn Iwinski 2012-07-22 04:36:15 UTC 
After a quick review:

[MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml

[MUST] Fix file-not-in-%lang rpmlint warnings

[SHOULD] %check is present and all tests pass

[SHOULD] Localized php.ini not necessary (see https://bugzilla.redhat.com/show_bug.cgi?id=785471#c5)
Comment 4 Remi Collet 2012-12-20 14:06:46 UTC 
Please update to 2.0.1
Comment 5 Nick Bebout 2013-02-05 22:50:01 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token-2.0.3-2.fc17.src.rpm
Comment 6 Remi Collet 2013-02-10 15:09:11 UTC 
[!]: License field in the package spec file matches the actual license.
	LGPLv2 (not LGPLv2+)

[!]: Package installs properly.
     Note: Installation errors (see attachment)
	Wait for dependencies before import in repository

Please fix the License, everything else seems OK.
Comment 7 Nick Bebout 2013-03-20 20:36:16 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token-2.0.3-3.fc17.src.rpm
Comment 8 Remi Collet 2013-03-21 15:44:50 UTC 
License fixed

No blocker

=== APPROVED ===
Comment 9 Nick Bebout 2013-03-21 15:56:33 UTC 
New Package SCM Request
=======================
Package Name: php-horde-Horde-Token
Short Description: A common abstracted interface into the various token generation mediums
Owners: nb remi
Branches: el6 f18 f19
InitialCC:
Comment 10 Gwyn Ciesla 2013-03-21 16:18:55 UTC 
Git done (by process-git-requests).
Comment 11 Fedora Update System 2013-03-22 00:34:01 UTC 
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.el6,php-horde-Horde-LoginTasks-2.0.2-4.el6,php-horde-Horde-Stream-Filter-2.0.1-4.el6,php-horde-Horde-Token-2.0.3-3.el6
Comment 12 Fedora Update System 2013-03-22 00:39:17 UTC 
php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.fc18,php-horde-Horde-Group-2.0.2-1.fc18,php-horde-Horde-LoginTasks-2.0.2-4.fc18,php-horde-Horde-Stream-Filter-2.0.1-4.fc18,php-horde-Horde-Token-2.0.3-3.fc18
Comment 13 Fedora Update System 2013-03-22 15:04:27 UTC 
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
Comment 14 Fedora Update System 2013-03-27 20:29:34 UTC 
php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been pushed to the Fedora 18 stable repository.
Comment 15 Fedora Update System 2013-03-28 18:39:51 UTC 
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository.
Note You need to log in before you can comment on or make changes to this bug.