Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 785449 (Horde_Browser) - Review Request: php-horde-Horde-Browser - Horde Browser API
Summary: Review Request: php-horde-Horde-Browser - Horde Browser API
Keywords:
Status: CLOSED RAWHIDE
Alias: Horde_Browser
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: horde-channel Horde_Exception Horde_Util
Blocks: Horde_Data Horde_Editor
TreeView+ depends on / blocked
 
Reported: 2012-01-29 01:10 UTC by Nick Bebout
Modified: 2013-03-21 15:47 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-20 22:00:38 UTC
Type: ---
Embargoed:
shawn: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
phpci.log (11.59 KB, text/x-log)
2012-12-19 18:36 UTC, Shawn Iwinski
no flags Details
php-horde-Horde-Browser-review.txt (6.23 KB, text/plain)
2012-12-19 18:36 UTC, Shawn Iwinski
no flags Details

Description Nick Bebout 2012-01-29 01:10:53 UTC
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Browser.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Browser-1.0.5-1.fc16.src.rpm
Description: The Horde_Browser class provides an API for getting information about the current user's browser and its capabilities.

Comment 2 Shawn Iwinski 2012-07-04 23:28:05 UTC
I will review this package

Comment 3 Nick Bebout 2012-07-19 16:47:15 UTC
I believe all of the normal blockers for the php-horde-Horde-* packages are fixed with this package.

Comment 4 Shawn Iwinski 2012-07-22 04:48:55 UTC
After a quick review:

[MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml

Comment 6 Shawn Iwinski 2012-12-19 18:36:23 UTC
Created attachment 666283 [details]
phpci.log

Comment 7 Shawn Iwinski 2012-12-19 18:36:47 UTC
Created attachment 666286 [details]
php-horde-Horde-Browser-review.txt

Comment 8 Shawn Iwinski 2012-12-19 18:40:45 UTC
===== COULD items =====
* Require php-pcre
* "s/pear.horde.org/%{pear_channel}/" and add "%global pear_channel pear.horde.org"


No blockers.


===== APPROVED =====

Comment 9 Nick Bebout 2012-12-19 21:10:20 UTC
New Package SCM Request
=======================
Package Name: php-horde-Horde-Browser
Short Description: The Horde_Browser class provides an API for getting information about the current user's browser and its capabilities
Owners: nb
Branches: f17 f18 el6
InitialCC: remi

Comment 10 Gwyn Ciesla 2012-12-20 11:45:37 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.