Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 785493 (Horde_Cli) - Review Request: php-horde-Horde-Cli - Horde Command Line Interface API
Summary: Review Request: php-horde-Horde-Cli - Horde Command Line Interface API
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: Horde_Cli
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: horde-channel Horde_Translation Horde_Support
Blocks: Horde_Test
TreeView+ depends on / blocked
 
Reported: 2012-01-29 04:25 UTC by Nick Bebout
Modified: 2013-03-21 15:43 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-12 22:49:19 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
php-horde-Horde-Cli-review.txt (8.02 KB, text/plain)
2012-08-02 12:33 UTC, Remi Collet 		no flags Details
View All

Description Nick Bebout 2012-01-29 04:25:35 UTC 
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cli.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cli-1.0.4-1.fc16.src.rpm
Description: Horde_Cli:: API for basic command-line functionality/checks
Comment 1 Shawn Iwinski 2012-06-23 13:19:45 UTC 
I am not an official package reviewer, but here are some comments I have for this package:



*** Per package.xml requirements, please add:

Requires: php-common >= 5.2.0



*** phpci results: For completeness (and to prevent any future packaging issues due to PHP package changes), you may wish to require the virtual packages "php-pcre" and "php-session".
Comment 2 Nick Bebout 2012-06-25 15:27:26 UTC 
I believe I have fixed these issues:

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cli.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cli-1.0.4-2.fc16.src.rpm
Comment 3 kc8hfi 2012-07-19 01:09:33 UTC 
I'm not an official package reviewer. I did see something about the BuildRequires.  It says php-channel(pear.horde.org).

I searched the repos for that, and found the php-channel-horde.  I installed that and the package built successfully.
Comment 4 Nick Bebout 2012-07-19 16:50:10 UTC 
I believe all of the normal blockers for the php-horde-Horde-* packages are fixed with this package.
Comment 5 Remi Collet 2012-08-02 12:33:52 UTC 
Created attachment 601938 [details]
php-horde-Horde-Cli-review.txt

Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09
Comment 6 Remi Collet 2012-08-02 12:35:17 UTC 
Could: localized php.ini is no more useful (timezone defined in pear wrapper)

Could: requires php(language) >= 5.2.0 per new PHP Guildelines, 
but this is fedora specific (for now), so php-common seems acceptable as you target both fedora/epel

No blocker

*** APPROVED ***
Comment 7 Nick Bebout 2012-08-02 20:32:44 UTC 
New Package SCM Request
=======================
Package Name: php-horde-Horde-Cli
Short Description: API for basic command-line functionality/checks
Owners: nb
Branches: el6 f16 f17
InitialCC:
Comment 8 Gwyn Ciesla 2012-08-02 23:21:09 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.