Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 785469 (Horde_LoginTasks) - Review Request: php-horde-Horde-LoginTasks - Horde Login Tasks System
Summary: Review Request: php-horde-Horde-LoginTasks - Horde Login Tasks System
Keywords:
Status: CLOSED ERRATA
Alias: Horde_LoginTasks
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: horde-channel Horde_Translation
Blocks: Horde_Core
TreeView+ depends on / blocked
 
Reported: 2012-01-29 02:45 UTC by Nick Bebout
Modified: 2013-03-28 18:39 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-27 20:28:55 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
phpci.log (11.44 KB, text/x-log)
2013-02-06 13:30 UTC, Remi Collet 		no flags Details
php-horde-Horde-LoginTasks-review.txt (7.13 KB, text/plain)
2013-02-06 13:30 UTC, Remi Collet 		no flags Details
View All

Description Nick Bebout 2012-01-29 02:45:33 UTC 
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks-1.0.3-1.fc16.src.rpm
Description: The Horde_LoginTasks library provides a set of methods for dealing with tasks run upon login to Horde applications.
Comment 1 Shawn Iwinski 2012-07-04 23:37:54 UTC 
I will review this package
Comment 2 Shawn Iwinski 2012-07-22 03:50:39 UTC 
After a quick review:

[MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml

[MUST] Fix file-not-in-%lang rpmlint warnings

[SHOULD] %check is present and all tests pass

[SHOULD] Localized php.ini not necessary (see https://bugzilla.redhat.com/show_bug.cgi?id=785471#c5)
Comment 3 Remi Collet 2012-12-20 14:04:42 UTC 
Please update to 2.0.1
Comment 4 Nick Bebout 2013-02-05 23:21:09 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks-2.0.2-2.fc17.src.rpm
Comment 5 Remi Collet 2013-02-06 13:30:01 UTC 
Created attachment 693926 [details]
phpci.log
Comment 6 Remi Collet 2013-02-06 13:30:36 UTC 
Created attachment 693927 [details]
php-horde-Horde-LoginTasks-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 785469
Comment 7 Remi Collet 2013-02-06 13:31:20 UTC 
[!]: License field in the package spec file matches the actual license.
	# Horde files are LGPLv2 (not LGPLv2+)
	# Horde/Image/Exif/Parser/Canon.php is GPLv2+
	=> GPLv2+ and LGPLv2

Just need to fix the License, else everything is ok.

Can you please replace my "private" email by my fp.o one ?
Comment 8 Remi Collet 2013-02-06 13:31:54 UTC 
[!]: License field in the package spec file matches the actual license.
	LGPLv2 (not LGPLv2+)

Just need to fix the License, else everything is ok.

Can you please replace my "private" email by my fp.o one ?
Comment 9 Remi Collet 2013-02-06 13:32:25 UTC 
ignore comment #7 (copy/paste error)
Comment 10 Nick Bebout 2013-02-06 21:01:41 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks-2.0.2-3.fc17.src.rpm
Comment 11 Remi Collet 2013-02-07 14:54:15 UTC 
It seems you miss the License field...
Comment 12 Nick Bebout 2013-03-20 20:31:44 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks-2.0.2-4.fc17.src.rpm
Comment 13 Remi Collet 2013-03-21 15:37:52 UTC 
License fixed.

=== APPROVED ===
Comment 14 Nick Bebout 2013-03-21 15:55:20 UTC 
New Package SCM Request
=======================
Package Name: php-horde-Horde-LoginTasks
Short Description: A set of methods for dealing with tasks run upon login to Horde applications
Owners: nb remi
Branches: el6 f18 f19
InitialCC:
Comment 15 Gwyn Ciesla 2013-03-21 16:21:15 UTC 
Git done (by process-git-requests).
Comment 16 Fedora Update System 2013-03-22 00:33:25 UTC 
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.el6,php-horde-Horde-LoginTasks-2.0.2-4.el6,php-horde-Horde-Stream-Filter-2.0.1-4.el6,php-horde-Horde-Token-2.0.3-3.el6
Comment 17 Fedora Update System 2013-03-22 00:37:29 UTC 
php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.fc18,php-horde-Horde-Group-2.0.2-1.fc18,php-horde-Horde-LoginTasks-2.0.2-4.fc18,php-horde-Horde-Stream-Filter-2.0.1-4.fc18,php-horde-Horde-Token-2.0.3-3.fc18
Comment 18 Fedora Update System 2013-03-22 15:04:04 UTC 
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
Comment 19 Fedora Update System 2013-03-27 20:28:59 UTC 
php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been pushed to the Fedora 18 stable repository.
Comment 20 Fedora Update System 2013-03-28 18:39:32 UTC 
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository.
Note You need to log in before you can comment on or make changes to this bug.