Bug 910119

Now we'll have as many command line parsing Node.js libraries in the distro as there are in the Python standard library!  :-p

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

Status: NEEDS WORK

Issues:
=======
[!]: The latest upstream version is 1.1.1.

     Please package the latest version or provide a rationale for packaging an
     older version.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.

MIT license in Readme.md so OK.

[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local

Node.js:
[x]: The package name is prefixed with "nodejs-" if it is a library
[x]: BuildRequires: nodejs-devel
[x]: Uses %{nodejs_sitelib} instead of hardcoding path
[x]: Uses tarball from the npm registry
[x]: If (and only if) this module is present in the npm registry, provides
     npm(<module_name>)
[x]: Runs %nodejs_symlink_deps in %install
[-]: Bundled modules are removed in %prep

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[!]: SourceX / PatchY prefixed with %{name}.
     Note: Source0 (commander-0.6.1.tgz) Source1 (tests-0.6.1.tar.bz2)
     Source10 (dl-tests.sh)
[x]: SourceX is a working URL.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
[-]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: nodejs-commander-0.6.1-1.fc19.src.rpm
          nodejs-commander-0.6.1-1.fc19.noarch.rpm
nodejs-commander.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-commander.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-commander.src: W: strange-permission dl-tests.sh 0755L
nodejs-commander.src: W: invalid-url Source1: tests-0.6.1.tar.bz2
nodejs-commander.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-commander.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-commander.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 7 warnings.

All ok.


Rpmlint (installed packages)
----------------------------
# rpmlint nodejs-commander
nodejs-commander.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-commander.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-commander.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'

Ditto.

Requires
--------
nodejs-commander-0.6.1-1.fc19.noarch.rpm (rpmlib, GLIBC filtered):
    
    nodejs(engine) >= 0.4.

Good (will look at dep generator to figure out what's causing that trailing dot
but it doesn't hurt anything and it's not your problem. ;-)

Provides
--------
nodejs-commander-0.6.1-1.fc19.noarch.rpm:
    
    nodejs-commander = 0.6.1-1.fc19
    npm(commander) = 0.6.1

Ok.

MD5-sum check
-------------
http://registry.npmjs.org/commander/-/commander-0.6.1.tgz :
  CHECKSUM(SHA256) this package     : 7b7fdd1bc4d16f6776169a64f133d629efe2e3a7cd338b1d0884ee909abbd729
  CHECKSUM(SHA256) upstream package : 7b7fdd1bc4d16f6776169a64f133d629efe2e3a7cd338b1d0884ee909abbd729


Generated by fedora-review 0.3.1 (f4bc12d) last change: 2012-10-16
Buildroot used: fedora-rawhide-vanilla-x86_64
Command line :./try-fedora-review -b910119

Please also document how the Source1 (tests) tarball is generated, per http://fedoraproject.org/wiki/Packaging:SourceURL

Thanks for the review! :)

> Now we'll have as many command line parsing Node.js libraries
> in the distro as there are in the Python standard library!  :-p

Heh :P



> Please package the latest version or provide a rationale for
> packaging an older version.

I have no rationale for packaging an older version other than "oops". Updated! (And now with an extra dep on nodejs-keypress: https://bugzilla.redhat.com/show_bug.cgi?id=910567 .)


> Good (will look at dep generator to figure out what's causing
> that trailing dot but it doesn't hurt anything and it's not your
> problem. ;-)

The package.json wants node >= 0.6.x so that's where the problem lies. I've added a patch for that in the spec but once the dep generator is fixed then I'll remove it.

diff -Naur a/package.json b/package.json
--- a/package.json
+++ b/package.json
@@ -9,5 +9,5 @@
   , "devDependencies": { "should": ">= 0.0.1" }
   , "scripts": { "test": "make test" }
   , "main": "index"
-  , "engines": { "node": ">= 0.6.x" }
+  , "engines": { "node": ">= 0.6.0" }
 }



> Please also document how the Source1 (tests) tarball is generated

Done.


Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-commander.spec
SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-commander-1.1.1-1.fc18.src.rpm

Ah, "> 0.6.x" is an invalid version specifier.  `man npm-json` says "You may not supply a comparator with a version containing an x."  Please notify upstream about this.  Though npm seems to be happy with it so I might fix the dep generator anyway.

I'll re-review the updated package once the new dep is done.

Pull request sent: https://github.com/visionmedia/commander.js/pull/127

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

Status: APPROVED

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local
  
===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[!]: SourceX / PatchY prefixed with %{name}.
     Note: Source0 (commander-1.1.1.tgz) Source1 (tests-1.1.1.tar.bz2)
     Source10 (dl-tests.sh)
[x]: SourceX is a working URL.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
  

Rpmlint
-------
Checking: nodejs-commander-1.1.1-1.fc19.src.rpm
          nodejs-commander-1.1.1-1.fc19.noarch.rpm
nodejs-commander.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-commander.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-commander.src: W: strange-permission dl-tests.sh 0755L
nodejs-commander.src: W: invalid-url Source1: tests-1.1.1.tar.bz2
nodejs-commander.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-commander.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-commander.noarch: W: only-non-binary-in-usr-lib
nodejs-commander.noarch: W: dangling-symlink /usr/lib/node_modules/commander/node_modules/keypress /usr/lib/node_modules/keypress
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

OK


Rpmlint (installed packages)
----------------------------
# rpmlint nodejs-commander
nodejs-commander.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-commander.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-commander.noarch: W: only-non-binary-in-usr-lib
nodejs-commander.noarch: W: dangling-symlink /usr/lib/node_modules/commander/node_modules/keypress /usr/lib/node_modules/keypress
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
# echo 'rpmlint-done:'

OK

Requires
--------
nodejs-commander-1.1.1-1.fc19.noarch.rpm (rpmlib, GLIBC filtered):
    
    nodejs(engine) >= 0.6.0
    npm(keypress) < 0.2
    npm(keypress) >= 0.1

OK

Provides
--------
nodejs-commander-1.1.1-1.fc19.noarch.rpm:
    
    nodejs-commander = 1.1.1-1.fc19
    npm(commander) = 1.1.1

OK

MD5-sum check
-------------
http://registry.npmjs.org/commander/-/commander-1.1.1.tgz :
  CHECKSUM(SHA256) this package     : 74fb42974e0964c7b9a097ced85b52495d820e04081daf133456a2c4c5d03a9f
  CHECKSUM(SHA256) upstream package : 74fb42974e0964c7b9a097ced85b52495d820e04081daf133456a2c4c5d03a9f

OK

Generated by fedora-review 0.3.1 (f4bc12d) last change: 2012-10-16
Buildroot used: fedora-rawhide-vanilla-x86_64
Command line :./try-fedora-review -b910119

New Package SCM Request
=======================
Package Name: nodejs-commander
Short Description: Node.js command-line interfaces made easy
Owners: jamielinux
Branches: f18 el6
InitialCC:

Git done (by process-git-requests).

nodejs-commander-1.1.1-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/nodejs-commander-1.1.1-1.fc18

nodejs-commander-1.1.1-1.fc18 has been pushed to the Fedora 18 testing repository.

nodejs-commander-1.1.1-1.fc18 has been pushed to the Fedora 18 stable repository.

nodejs-commander-1.1.1-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/nodejs-commander-1.1.1-1.el6

nodejs-commander-1.1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.