Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 915907 (qt5-qtquick1)
| Summary: | Review Request: qt5-qtquick1 - A declarative language for describing user interfaces in Qt5 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, lkundrak, notting |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | qt5-qtquick1-5.1.1-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-29 01:30:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 878188, 915005, 915006, 915902 | ||
| Bug Blocks: | 656997, 928937 | ||
|
Description
Rex Dieter
2013-02-26 18:35:30 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtquick1.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtquick1-5.0.2-1.fc18.src.rpm %changelog * Thu Apr 11 2013 Rex Dieter <rdieter> 5.0.2-1 - 5.0.2 Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtquick1.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtquick1-5.1.1-1.fc19.src.rpm %changelog * Tue Sep 03 2013 Rex Dieter <rdieter> 5.1.1-1 - 5.1.1 Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5904746 * Name is OK
* Distfile matches upstream
* Versioned correctly, packaging latest version
* Properly licensed for Fedora
* SPEC file clean and legible
* Builds fine in mock
* Provides list sane
* Requires sane
* Filelist makes sense
* Headers and .so files properly packed in -devel subpackage
* Proper compiler flags used
- rpmlint not happy about no documentation
- license text not present
0.) These things from rpmlint probably need attention:
Please check if this is okay:
qt5-qtquick1.x86_64: E: zero-length /usr/lib64/qt5/imports/QtWebKit/plugins.qmltypes
Use double %% here:
qt5-qtquick1.src:45: W: macro-in-comment %{_bindir}
1.) No documentation & License
Please include these in %doc
$ find |grep -i license
./qtquick1-opensource-src-5.1.1/src/doc/src/legal/qtdeclarativelicense.qdoc
./qtquick1-opensource-src-5.1.1/LICENSE.FDL
./qtquick1-opensource-src-5.1.1/LICENSE.LGPL
./qtquick1-opensource-src-5.1.1/LICENSE.GPL
2.) Name, summary and description are way too short
It might be a good idea to turn them into something more descriptive.
0 looks harmless, afaict. 1. no docs currently get installed, so can skip FDL references Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtquick1.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtquick1-5.1.1-2.fc19.src.rpm %changelog * Mon Sep 16 2013 Rex Dieter <rdieter> 5.1.1-2 - %%doc LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt - escape macros in comments - better %%description/%%summary Looks fine now. Thank you! APPROVED New Package SCM Request ======================= Package Name: qt5-qtquick1 Short Description: A declarative language for describing user interfaces in Qt5 Owners: rdieter than jreznik kkofler ltinkl rnovacek Branches: f18 f19 f20 el6 InitialCC: Git done (by process-git-requests). qt5-qtquick1-5.1.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/qt5-qtquick1-5.1.1-2.fc18 qt5-qtquick1-5.1.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/qt5-qtquick1-5.1.1-2.fc19 qt5-qtquick1-5.1.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/qt5-qtquick1-5.1.1-2.fc20 qt5-qtquick1-5.1.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/qt5-qtquick1-5.1.1-2.el6 qt5-qtquick1-5.1.1-2.fc20 has been pushed to the Fedora 20 testing repository. qt5-qtquick1-5.1.1-2.fc18 has been pushed to the Fedora 18 stable repository. qt5-qtquick1-5.1.1-2.fc20 has been pushed to the Fedora 20 stable repository. qt5-qtquick1-5.1.1-2.fc19 has been pushed to the Fedora 19 stable repository. qt5-qtquick1-5.1.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |