Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 915909 (qt5-qtdeclarative)
Summary: | Review Request: qt5-qtdeclarative - Qt5 - QtDeclarative component | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> | ||||
Component: | Package Review | Assignee: | Gregor Tätzner <gregor> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | gregor, hobbes1069, kevin, notting, package-review | ||||
Target Milestone: | --- | Flags: | gregor:
fedora-review+
gwync: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | qt5-qtsvg-5.0.2-1.fc18 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2013-08-02 13:19:38 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 878188, 915903 | ||||||
Bug Blocks: | 656997, 928937, 915006, 915910 | ||||||
Attachments: |
|
Description
Rex Dieter
2013-02-26 18:38:11 UTC
Rats, hit a conflict today working on 5.0.2: file /usr/bin/qmlplugindump from install of qt5-qtdeclarative-5.0.2-1.fc18.x86_64 conflicts with file from package qt-devel-1:4.8.4-14.fc18.x86_64 Anyway, work in progress: Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdeclarative.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdeclarative-5.0.2-1.fc18.src.rpm %changelog * Thu Apr 11 2013 Rex Dieter <rdieter> 5.0.2-1 - 5.0.2 Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdeclarative.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdeclarative-5.0.2-2.fc18.src.rpm %changelog * Fri Apr 12 2013 Rex Dieter <rdieter> 5.0.2-2 - fix conflicts with qt4-devel Created attachment 737355 [details]
pre-review
looks good, just some items:
- license tag doesn't reflect the actual licenses: LGPL, GPL and FDL
- include license files in %doc
- also the changelog within dist directory
- imho examples should also be packaged (doc-subpkg?)
- consider to suffix all binaries with -qt5, not only qmlplugindump
- lots of hidden files in debuginfo (*.moc)
Some comments before posting new spec: - I don't see anything packaged that actually uses FDL. If you do, can you please clarify where it is? - adding an -examples subpkg would be nice, but I'd rather do that post review after dealing with blocker items - consider to suffix all binaries with -qt5: (current) strategy is too only add postfixes for conflicting items - lots of hidden files in debuginfo (*.moc) : I'm not eager to modify upstream buildsystem if the only purpose is to satisfy rpmlint's mostly-harmless warning here. Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdeclarative.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdeclarative-5.0.2-2.fc18.src.rpm %changelog * Fri Apr 12 2013 Rex Dieter <rdieter> 5.0.2-2 - fix conflicts with qt4-devel - include license files, dist/changes* ping, any remaining review blockers or fixes you'd like to see? (In reply to comment #4) > Some comments before posting new spec: > > - I don't see anything packaged that actually uses FDL. If you do, can you > please clarify where it is? Nay, we don't include any *.qdoc files. Maybe you wanna add a comment so you won't forget. (In reply to comment #6) > ping, any remaining review blockers or fixes you'd like to see? no further objections from my side...gonna approve this component. diff -r -Nup qt5-qtdeclarative-5.0.2-1.fc18.src/qt5-qtdeclarative.spec qt5-qtdeclarative-5.0.2-2.fc18.src/qt5-qtdeclarative.spec --- qt5-qtdeclarative-5.0.2-1.fc18.src/qt5-qtdeclarative.spec 2013-04-11 18:28:16.000000000 +0200 +++ qt5-qtdeclarative-5.0.2-2.fc18.src/qt5-qtdeclarative.spec 2013-05-09 16:10:21.000000000 +0200 @@ -4,9 +4,9 @@ Summary: Qt5 - QtDeclarative component Name: qt5-%{qt_module} Version: 5.0.2 -Release: 1%{?dist} +Release: 2%{?dist} -# See LGPL_EXCEPTIONS.txt, LICENSE.GPL3, respectively, for exception details +# See LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt, for details License: LGPLv2 with exceptions or GPLv3 with exceptions Url: http://qt-project.org/ Source0: http://releases.qt-project.org/qt5/%{version}%{?pre:-%{pre}}/submodules/%{qt_module}-opensource-src-%{version}.tar.xz @@ -38,7 +38,6 @@ Requires: %{name}-devel%{?_isa} = %{vers %build - %{_qt5_qmake} make %{?_smp_mflags} @@ -53,7 +52,7 @@ mkdir %{buildroot}%{_bindir} pushd %{buildroot}%{_qt5_bindir} for i in * ; do case "${i}" in - foobar) + qmlplugindump) mv $i ../../../bin/${i}-qt5 ln -s ../../../bin/${i}-qt5 . ln -s ../../../bin/${i}-qt5 $i @@ -83,17 +82,19 @@ popd %postun -p /sbin/ldconfig %files +%doc LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt +%doc dist/changes* %{_qt5_libdir}/libQt5Qml.so.5* %{_qt5_libdir}/libQt5Quick.so.5* %{_qt5_libdir}/libQt5QuickParticles.so.5* %{_qt5_libdir}/libQt5QuickTest.so.5* -%{_qt5_bindir}/qml* -%{_bindir}/qml* %{_qt5_plugindir}/accessible/libqtaccessiblequick.so %{_qt5_plugindir}/qmltooling/ %{_qt5_archdatadir}/qml/ %files devel +%{_bindir}/qml* +%{_qt5_bindir}/qml* %{_qt5_headerdir}/Qt*/ %{_qt5_libdir}/libQt5Qml.so %{_qt5_libdir}/libQt5Qml.prl @@ -109,6 +110,10 @@ popd %changelog +* Fri Apr 12 2013 Rex Dieter <rdieter> 5.0.2-2 +- fix conflicts with qt4-devel +- include license files, dist/changes* + * Thu Apr 11 2013 Rex Dieter <rdieter> 5.0.2-1 - 5.0.2 yay, thanks! New Package SCM Request ======================= Package Name: qt5-qtdeclarative Short Description: Qt5 - QtDeclarative components Owners: than rdieter jreznik kkofler ltinkl rnovacek Branches: f17 f18 f19 InitialCC: fyi, before issuing any official builds, need to fix another conflict (with qt-creator this time): file /usr/bin/qmlprofiler from install of qt5-qtdeclarative-devel-5.0.2-2.fc17.x86_64 conflicts with file from package qt-creator-2.4.1-2.fc17.x86_64 Git done (by process-git-requests). imported, waiting on qt5-qtjsbackend review (bug #915903 ) before doing any builds. qt5-qtsvg-5.0.2-1.fc19,qt5-qtwebkit-5.0.2-7.fc19,qt5-qtdeclarative-5.0.2-3.fc19,qt5-qtjsbackend-5.0.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/qt5-qtsvg-5.0.2-1.fc19,qt5-qtwebkit-5.0.2-7.fc19,qt5-qtdeclarative-5.0.2-3.fc19,qt5-qtjsbackend-5.0.2-2.fc19 qt5-qtsvg-5.0.2-1.fc18,qt5-qtwebkit-5.0.2-7.fc18,qt5-qtdeclarative-5.0.2-3.fc18,qt5-qtjsbackend-5.0.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/qt5-qtsvg-5.0.2-1.fc18,qt5-qtwebkit-5.0.2-7.fc18,qt5-qtdeclarative-5.0.2-3.fc18,qt5-qtjsbackend-5.0.2-2.fc18 qt5-qtsvg-5.0.2-1.fc19, qt5-qtwebkit-5.0.2-7.fc19, qt5-qtdeclarative-5.0.2-3.fc19, qt5-qtjsbackend-5.0.2-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. qt5-qtsvg-5.0.2-1.fc18, qt5-qtwebkit-5.0.2-7.fc18, qt5-qtdeclarative-5.0.2-3.fc18, qt5-qtjsbackend-5.0.2-2.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: qt5-qtdeclarative New Branches: el6 Owners: hobbes1069 InitialCC: Needed for future review request. Co-maintainers welcomed! Git done (by process-git-requests). |