Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 915913 (qtgraphicaleffects)
Summary: | Review Request: qt5-qtgraphicaleffects - Qt5 - QtGraphicalEffects component | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | kevin, lkundrak, notting |
Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | qt5-qtgraphicaleffects-5.1.1-1.el6 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-09-03 12:08:03 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 878188 | ||
Bug Blocks: | 656997, 928937 |
Description
Rex Dieter
2013-02-26 18:45:52 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtgraphicaleffects.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtgraphicaleffects-5.0.2-1.fc18.src.rpm %changelog * Thu Apr 11 2013 Rex Dieter <rdieter> 5.0.2-1 - 5.0.2 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5244011 * Package named properly - Latest version not used, probably fine - License text is not present - The SPEC file in SRPM and one linked to differ (see below) - SPEC file clean and legible * Require list sane * Provides sane * Filelist sane - Debuginfo package empty * Owns all files it should own * Builds fine in mock 0.) You refer to license files in a comment, but don't ship any documentation Please clarify which package are livense files in, and possibly ask upstream to include full license text. 1.) Please make sure the package uses correct Source tag, your two SPEC files differ: -Source0: http://download.qt-project.org/archive/qt/5.0/%{version}/submodules/%{qt_module}-opensource-src-%{version}.tar.xz +Source0: http://releases.qt-project.org/qt5/%{version}%{?pre:-%{pre}}/submodules/%{qt_module}-opensource-src-%{version}.tar.xz 2.) Please disable generation of debuginfo package (or turn it noarch -- qml files look like they shoul belong to datadir instead of libdir) 3.) Please consider using more useful description Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtgraphicaleffects.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtgraphicaleffects-5.0.2-2.fc19.src.rpm %changelog * Wed Aug 28 2013 Rex Dieter <rdieter> 5.0.2-2 - update Source URL - clarify license comment - disable -debuginfo updated description too, same URLs, %changelog * Wed Aug 28 2013 Rex Dieter <rdieter> 5.0.2-2 - improved description - update Source URL - clarify license comment - disable -debuginfo Thank you, looks fine. APPROVED New Package SCM Request ======================= Package Name: qt5-qtgraphicaleffects Short Description: Qt5 - QtGraphicalEffects component Owners: than rdieter jreznik kkofler ltinkl rnovacek Branches: f18 f19 f20 InitialCC: Git done (by process-git-requests). imported Package Change Request ====================== Package Name: qt5-qtgraphicaleffects New Branches: el6 Owners: rdieter InitialCC: Co-maintainers welcome! Git done (by process-git-requests). qt5-qtgraphicaleffects-5.1.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/qt5-qtgraphicaleffects-5.1.1-1.el6 qt5-qtgraphicaleffects-5.1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |