Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 98520
| Summary: | UTF-8 locale and empty tips | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Akira TAGOH <tagoh> |
| Component: | gimp | Assignee: | Nils Philippsen <nphilipp> |
| Status: | CLOSED RAWHIDE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 1 | CC: | christoph.wickert, eng-i18n-bugs |
| Target Milestone: | --- | Keywords: | i18n |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.2.5-2 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2004-09-13 03:32:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 101377 | ||
| Bug Blocks: | |||
| Attachments: | |||
Okay.. Should we iconv all tips text file to UTF-8 for Cambridge? Yes, it should solves this problem. Created attachment 96465 [details]
proposed patch
the encoding of tips files can be guessed from the po files, I think. so
attached patch will just try to convert all tips files to UTF-8.
*** Bug 110329 has been marked as a duplicate of this bug. *** Created attachment 96690 [details]
patch to iconv UTF-8 tips files to the native locale
This patch also supports to be ran on the native locale.
how is this going on? and can we get a chance to fix this on FC1 updates? This problem causes really unusable for the newbie gimp users who want to know the tips on Japanese. I'm looking at the patch now and will likely put an updated package out soon. BTW: Am I supposed to apply both patches or only the second one? I looked at your second patch and it seems like it isn't quite consistent in using newly allocated and static strings... Guess I'll need to overhaul the patch a bit. Created attachment 99229 [details]
overhauled patch to iconv UTF-8 tips files to the native locale
this patch strdup()s in store_tip() so we only have newly allocated strings in
tips_text[].
Created attachment 99230 [details]
fixed overhauled patch to iconv UTF-8 tips files to the native locale
D'oh
Guess I'll have to apply the first patch as well... Yes, the patch is assuming all of po files are UTF-8. please test gimp-1.2.5-2 confirmed the fix. thanks. doh, this package wasn't pushed to FC1-updates. reopening and reverting the status. Confirmed fixed in FC1-update; gimp-1.2.5-2 Tested in the following locale: ja_JP ja_JP.UTF-8 ko_KR ko_KR.UTF-8 zh_CN.GB18030 zh_CN.UTF-8 zh_TW.Bug5 zh_TW.UTF-8 Thanks, Lawrence |
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.2.1) Gecko/20030225 Description of problem: When I run GIMP with UTF-8 locale, empty tips are displayed so that the tips files is stored as the legacy encoding. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1.LANG=ja_JP.UTF-8 gimp, for example 2. 3. Additional info: