1. Summary:        Simple tool for managing conky scripts.

Never leave a dot "." at the end of the summary tag.

2. Ask upstream to add download support on https://launchpad.net/conky-manager/ so it will be easier to retrieve sources.

To me the source is located at 

https://launchpad.net/~teejee2008/+archive/ppa/+files/conky-manager_1.2.0.1.tar.gz

3. Remove explicit requires

Requires:       conky, lm_sensors, hddtemp, p7zip, p7zip-plugins, libgee06


e.g libgee06 can be automatically detected during installation.

4. %{_datadir}/applications/conky-manager.desktop

You should use desktop-file-install to install/validate it.

http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

5. make missing smp flags.

http://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make

6. It's nonsense to write

(stable version)

in description.

7. Don't leave blank lines in %changelog.

Fix in progress >>>
Thank You

All Done :

Spec : http://ojuba.org/oji/SPECS/conky-manager-1.2.0.1-3.spec
SRPM : http://ojuba.org/oji/SRPMS/conky-manager-1.2.0.1-2.oji.fc19.src.rpm

Sorry error in spec link :

All Done :

Spec : http://ojuba.org/oji/SPECS/conky-manager-1.2.0.1-2.spec
SRPM : http://ojuba.org/oji/SRPMS/conky-manager-1.2.0.1-2.oji.fc19.src.rpm

Hi Mosaab 

I would like have this package in Fedora repositories, would be nice for end users  to have a gui for conky.

- naming of the spec is wrong, the name must be the same of the upstream, just conky-manager 

- i think that url should be http://teejeetech.blogspot.in/p/conky-manager.html

- licenses tag is wrong,licenses should be GPLv... not GPL... also the package is GPLv3 according to the COPYING file but have some files under GPLv2+, i think that package should be just GPLv3+


GPL (v2 or later)
-----------------
/home/echevemaster/1015867-conky-manager-1.2.0.1-2/upstream-unpacked/Source0/conky-manager-1.2.0.1/src/Main.vala
/home/echevemaster/1015867-conky-manager-1.2.0.1-2/upstream-unpacked/Source0/conky-manager-1.2.0.1/src/MainWindow.vala
/home/echevemaster/1015867-conky-manager-1.2.0.1-2/upstream-unpacked/Source0/conky-manager-1.2.0.1/src/Utility.vala

one question, themepacks should be compressed for run?
rpmls conky-manager-1.2.0.1-2.fc20.x86_64.rpm 
-rwxr-xr-x  /usr/bin/conky-manager
-rw-r--r--  /usr/share/applications/conky-manager.desktop
-rw-r--r--  /usr/share/conky-manager/images/conky-manager.png
-rw-r--r--  /usr/share/conky-manager/images/conky-manager.xcf
-rw-r--r--  /usr/share/conky-manager/themepacks/default-themes-1.1.cmtp.7z
-rw-r--r--  /usr/share/conky-manager/themepacks/default-themes-1.2.cmtp.7z
drwxr-xr-x  /usr/share/doc/conky-manager
-rw-r--r--  /usr/share/doc/conky-manager/AUTHORS
-rw-r--r--  /usr/share/doc/conky-manager/COPYING
-rw-r--r--  /usr/share/doc/conky-manager/README
-rw-r--r--  /usr/share/doc/conky-manager/TODO
-rwxr-xr-x  /usr/share/pixmaps/conky-manager.png

- it's expected that BR are devel packages, in this case vala-devel is the correct

- please stop the use of pkconfig in BR, retrieving of dependencies is more slow using this way. do you want to know the name of the packages? use repoquery

repoquery -qf 'pkgconfig(glib-2.0)'
glib2-devel-0:2.36.3-2.fc19.i686
glib2-devel-0:2.36.3-3.fc19.i686
glib2-devel-0:2.36.3-2.fc19.x86_64
glib2-devel-0:2.36.3-3.fc19.x86_64

repoquery -qf 'pkgconfig(gtk+-3.0)'    
gtk3-devel-0:3.8.4-1.fc19.i686
gtk3-devel-0:3.8.4-1.fc19.x86_64
gtk3-devel-0:3.8.2-2.fc19.i686
gtk3-devel-0:3.8.2-2.fc19.x86_64

repoquery -qf 'pkgconfig(gee-1.0)' 
libgee06-devel-0:0.6.8-1.fc19.x86_64
libgee06-devel-0:0.6.8-1.fc19.i686

- Please give a name more explicit to the patch, conky0.patch doesn't says anything about with it does the patch 

- there are a typo in the description 
Concky manger improves conky effects to be beautiful and simple.

also there are a better description in launchpad

"A simple GUI for managing Conky config files. Options for changing themes and running Conky at startup."

if the tarball meets with the way %{name}-%{version} isn't needed -n option
%setup -qn %{name}-%{version}

- Don't needed wilcards (*.*) in this case for listing the files 

Regards

Thank You ,, I'll fix .

But in BR we need (vala) to build conky-manger , vala-devel will be extra . Even vala-devel require vala but only vala does what we need .


Regards

Use GPLv3+ instead of GPL2 ??

-----
> one question, themepacks should be compressed for run?

Yes

Ok, All done.

Spec : http://ojuba.org/oji/SPECS/conky-manager.spec
SRPM : http://ojuba.org/oji/SRPMS/conky-manager-1.2.0.1-2.oji.fc19.src.rpm

- To zero warnings by rpmlint.

Spec : http://ojuba.org/oji/SPECS/conky-manager.spec
SRPM : http://ojuba.org/oji/SRPMS/conky-manager-1.2.0.1-3.oji.fc19.src.rpm

RAWHIDE : http://koji.fedoraproject.org/koji/taskinfo?taskID=6543919
F20 : http://koji.fedoraproject.org/koji/taskinfo?taskID=6543932
F19 : http://koji.fedoraproject.org/koji/taskinfo?taskID=6543950
EPEL7 : http://koji.fedoraproject.org/koji/taskinfo?taskID=6543954

Update to 2.2:

Spec: http://ojuba.org/test/conky-manager.spec
Srpm: http://ojuba.org/test/conky-manager-2.2-1.oj35.src.rpm

Review:

+ package built fine in mock rawhide(x86_64)

- rpmlint on generated rpms gave output
conky-manager.src: W: strange-permission conky-manager_2.2~118~ubuntu14.04.1.tar.gz 0640L
conky-manager.x86_64: E: script-without-shebang /usr/share/conky-manager/images/view-preview.svg
conky-manager.x86_64: E: script-without-shebang /usr/share/conky-manager/images/help-info.svvg
conky-manager.x86_64: E: script-without-shebang /usr/share/conky-manager/images/donate.svg
conky-manager.x86_64: E: script-without-shebang /usr/share/conky-manager/images/view-list.svg
conky-manager.x86_64: W: no-manual-page-for-binary conky-manager
conky-manager-debuginfo.x86_64: E: debuginfo-without-sources
3 packages and 0 specfiles checked; 5 errors, 2 warnings.

+ Source verified with upstream as (sha256sum)
upstream tarball: 8ee789d56a42d178a7c69b24c7e099c27592d088fef4a07ccdf8439598a9dba5
srpm tarball: 8ee789d56a42d178a7c69b24c7e099c27592d088fef4a07ccdf8439598a9dba5

+ License is "GPLv3+" and its text is included in vala source headers as GPLv2+ and in COPYING as GPLv3+


Suggestions:
1) Group tag is optional for Fedora and can be removed

2) Patch0 should be written below source0 line

3) patch name should always be start like %{name}-%{version}-desktopentry-fixer-and-arabizer.patch

4) in %prep, good to add patch level also
%patch0 -p0

5) To preserve the timestamp of upstream files getting installed directly use
make install DESTDIR=%{buildroot} INTALL="install -p"

6) following lines should be at the end of %install section not in the middle
desktop-file-install %{buildroot}/%{_datadir}/applications/conky-manager.desktop
%find_lang %{name}

7) desktop-file-install when used should use --dir option see the usage as given in https://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage

8) in %files section instead of following 2 lines 
%{_datadir}/conky-manager/images/
%{_datadir}/conky-manager/themepacks/

just write
%{_datadir}/conky-manager

This will make sure this package will also own directory /usr/share/conky-manager

9) The MimeType in desktop file is kept empty. Check with upstream to remove it or you can remove it using
sed -i '3d' conky-manager.desktop 

Reason I am asking this is if there is MimeType then we need to add update-desktop-database scriptlet

10) fix any other rpmlint message

submit new srpm for further review

Done:


Spec: http://ojuba.org/test/conky-manager.spec
Srpm: http://ojuba.org/test/conky-manager-2.2-2.oj35.src.rpm

1) oops sorry I should mean actually use this
make install DESTDIR=%{buildroot} INSTALL="install -p"

2) you are using command desktop-file-install as I said its usage recommends to use --dir so it should be like
desktop-file-install \
     --dir=%{buildroot}%{_datadir}/applications \
     %{name}.desktop

3) debuginfo is not generating properly. See
$ rpmlint conky-manager-debuginfo-2.2-2.fc21.x86_64.rpm
conky-manager-debuginfo.x86_64: E: debuginfo-without-sources
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

+ desktop-file-install --dir=/home/moceap/rpmbuild/BUILDROOT/conky-manager-2.2-3.oj35.i386/usr/share/applications/ conky-manager.desktop
Error on file "conky-manager.desktop": No such file or directory

- Fix typo in %%install.
- Enable debugging.
==========



Spec: http://ojuba.org/test/conky-manager.spec
Srpm: http://ojuba.org/test/conky-manager-2.2-3.oj35.src.rpm

1) Note I have never seen such desktop-file-install usage and as per guidelines you need to use --dir option. About the above error, I missed to type "src/" so it should be actually

desktop-file-install \
     --dir=%{buildroot}%{_datadir}/applications \
       src/%{name}.desktop



otherwise looks good. Make sure you fix above before importing this package in dist-git

APPROVED.

Don't worry!
Thank you, And I updated spec to (3 words summary ^_")

New Package SCM Request
=======================
Package Name: conky-manager
Short Description: Conky scripts manager
Owners: moceap
Branches: f19 f20 f21 epel7

Git done (by process-git-requests).

conky-manager-2.2-3.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/conky-manager-2.2-3.el7

conky-manager-2.2-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/conky-manager-2.2-3.fc21

conky-manager-2.2-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/conky-manager-2.2-3.fc20

conky-manager-2.2-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/conky-manager-2.2-3.fc19

conky-manager-2.2-3.el7 has been pushed to the Fedora EPEL 7 testing repository.

conky-manager-2.3.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/conky-manager-2.3.1-1.fc21

conky-manager-2.3.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/conky-manager-2.3.1-1.fc20

conky-manager-2.3.1-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/conky-manager-2.3.1-1.fc19

conky-manager-2.3.1-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/conky-manager-2.3.1-1.el7

conky-manager-2.3.1-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

conky-manager-2.3.1-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

conky-manager-2.3.1-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

conky-manager-2.3.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.