Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1020309 (kde-connect) - Review Request: kde-connect - KDE Connect client for communication with smartphones
Summary: Review Request: kde-connect - KDE Connect client for communication with smart...
Keywords:
Status: CLOSED ERRATA
Alias: kde-connect
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2013-10-17 12:22 UTC by Martin Bříza
Modified: 2014-01-11 08:42 UTC (History)
9 users (show)

Fixed In Version: kde-connect-0.4.2-1.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-04 19:54:04 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Martin Bříza 2013-10-17 12:22:09 UTC 
Spec URL: http://mbriza.fedorapeople.org/kdeconnect/kde-connect.spec
SRPM URL: http://mbriza.fedorapeople.org/kdeconnect/kde-connect-0.3-1.fc19.src.rpm
Description: KDE Connect adds communication between KDE and your smartphone.
Currently, you can pair with your Android phone using the KDE Connect app from
Albert Vaka which you can obtain on Google Play.
Fedora Account System Username: mbriza
Comment 1 Volker Fröhlich 2013-10-17 21:12:24 UTC 
I wrote a draft of that and had BRs on qca2-devel and qjson-devel.
Comment 2 Mario Blättermann 2013-10-20 18:54:44 UTC 
Scratch build fails for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6081716

From build.log:

CMake Error at kded/plugins/ping/CMakeLists.txt:2 (find_package):
  By not providing "FindQJSON.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "QJSON", but
  CMake did not find one.
  Could not find a package configuration file provided by "QJSON" with any of
  the following names:
    QJSONConfig.cmake
    qjson-config.cmake
  Add the installation prefix of "QJSON" to CMAKE_PREFIX_PATH or set
  "QJSON_DIR" to a directory containing one of the above files.  If "QJSON"
  provides a separate development package or SDK, be sure it has been
  installed.
-- Configuring incomplete, errors occurred!
See also "/builddir/build/BUILD/kdeconnect-kde-0.3/x86_64-redhat-linux-gnu/CMakeFiles/CMakeOutput.log".
See also "/builddir/build/BUILD/kdeconnect-kde-0.3/x86_64-redhat-linux-gnu/CMakeFiles/CMakeError.log".
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.Px6LmD (%build)
    Bad exit status from /var/tmp/rpm-tmp.Px6LmD (%build)

This confirms what Volker wrote.
Comment 3 Martin Bříza 2013-11-07 18:38:13 UTC 
Spec URL: http://mbriza.fedorapeople.org/kdeconnect/kde-connect.spec
SRPM URL: http://mbriza.fedorapeople.org/kdeconnect/kde-connect-0.3-1.fc19.src.rpm

Updated, added BR: qca2-devel, qjson-devel, gettext
Comment 4 Volker Fröhlich 2013-11-09 11:39:34 UTC 
New versions are available.
Comment 5 Rex Dieter 2013-11-18 21:29:48 UTC 
It sometimes releases fast, keeping up will mean the review never finishes.  I'd suggest reviewing what is available from comment #3
Comment 6 Martin Bříza 2013-11-28 14:49:22 UTC 
Spec URL: http://mbriza.fedorapeople.org/kdeconnect/kde-connect.spec
SRPM URL: http://mbriza.fedorapeople.org/kdeconnect/kde-connect-0.4.2-1.fc19.src.rpm

Updated to latest upstream release + some minor fixes in the spec
Comment 7 Rex Dieter 2013-12-14 23:29:41 UTC 
scratch build for giggles,
http://koji.fedoraproject.org/koji/taskinfo?taskID=6295776
Comment 8 Dan Mossor [danofsatx] 2013-12-15 02:35:33 UTC 
Scratch build for F20:

http://koji.fedoraproject.org/koji/taskinfo?taskID=6295776

Have it installed in F20 Gold, and it is mostly working. A few  small bugs, like volume controls (which could be my kmix, not the app), and no documentation.

For completion sake, the app works over WiFi, not Bluetooth. It communicates with the mobile device via port 1714 which is listed in /etc/services as sesi-lm.

The Android app can be found here:

https://play.google.com/store/apps/details?id=org.kde.kdeconnect_tp
Comment 9 Rex Dieter 2013-12-20 15:27:38 UTC 
I will help with review, have time today (with volter's assent discussed on irc)
Comment 10 Rex Dieter 2013-12-20 15:36:14 UTC 
naming: ok

license: ok

macros: ok

sources: ok
96320feda9805296c72e1e10578b903e  kdeconnect-kde-0.4.2.tar.xz

scriptlets: ok

builds/installs/runs: ok

1. MUST: minor issues with dir ownership, these end up unowned:
%{_kde4_libdir}/kde4/imports/org/kde/kdeconnect/
%{_kde4_appsdir}/plasma/plasmoids/kdeconnect/

2. SHOULD: omit extraneous build dep
BuildRequires: cmake
(already pulled in by kdelibs-devel)

Those 2 issues are minor, and can be fixed post import and prior to doing any official builds.


APPROVED.
Comment 11 Martin Bříza 2013-12-24 01:40:54 UTC 
New Package SCM Request
=======================
Package Name: kde-connect
Short Description: KDE Connect client for communication with smartphones
Owners: mbriza than rdieter kkofler ltinkl jgrulich dvratil
Branches: f18 f19 f20
InitialCC:
Comment 12 Gwyn Ciesla 2013-12-24 12:46:23 UTC 
Git done (by process-git-requests).
Comment 13 Fedora Update System 2014-01-02 13:20:40 UTC 
kde-connect-0.4.2-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/kde-connect-0.4.2-1.fc19
Comment 14 Fedora Update System 2014-01-02 13:26:59 UTC 
kde-connect-0.4.2-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/kde-connect-0.4.2-1.fc20
Comment 15 Fedora Update System 2014-01-03 08:35:47 UTC 
kde-connect-0.4.2-1.fc19 has been pushed to the Fedora 19 testing repository.
Comment 16 Fedora Update System 2014-01-04 19:54:04 UTC 
kde-connect-0.4.2-1.fc20 has been pushed to the Fedora 20 stable repository.
Comment 17 Fedora Update System 2014-01-11 08:42:47 UTC 
kde-connect-0.4.2-1.fc19 has been pushed to the Fedora 19 stable repository.
Note You need to log in before you can comment on or make changes to this bug.