Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1037377 - vodovod FTBFS if "-Werror=format-security" flag is used
Summary: vodovod FTBFS if "-Werror=format-security" flag is used
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: vodovod
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Karel Volný
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1038070 1038075
Blocks: 1038083
TreeView+ depends on / blocked
 
Reported: 2013-12-03 06:04 UTC by Dhiru Kholia
Modified: 2014-03-25 03:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-03 18:57:26 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Dhiru Kholia 2013-12-03 06:04:47 UTC 
Description of problem
----------------------

vodovod fails to build if "-Werror=format-security" flag is used.

...

allmenus.cpp:367:69: error: format not a string literal and no format arguments [-Werror=format-security]
allmenus.cpp:370:69: error: format not a string literal and no format arguments [-Werror=format-security]
njamfont.cpp:119:44: error: format not a string literal and no format arguments [-Werror=format-security]
njamfont.cpp:128:44: error: format not a string literal and no format arguments [-Werror=format-security]

...

We are working on a proposal to enable "-Werror=format-security" for all
packages. Once this flag is enabled, GCC will refuse to compile code that could
be vulnerable to a string format security flaw. For more details, please see
https://fedorahosted.org/fesco/ticket/1185 page.

To understand why it is important to fix this, please see
https://fedoraproject.org/wiki/Format-Security-FAQ page.

How to fix this
---------------

The fix for these errors is quite simple. It's a matter of changing a
line like,

   printf(foo);

to read,

   printf("%s", foo);

That's it.

Please fix this issue in rawhide with a patch (which you should submit
to upstream to merge moving forward). Please do a new build with the
fix in rawhide. Other releases do not need to be directly fixed, but
there should be no harm in pushing out this fix/patch with other needed
changes to those branches.

In the event you don't fix this bug before the next mass rebuild,
provenpackagers may step in and update your package(s) to fix this
issue.

How reproducible
----------------

Build vodovod-1.10r19-12.fc20.src.rpm with "-Werror=format-security" flag to reproduce the problem.

To make this process easier, you can use a modified "redhat-rpm-config" package
from http://people.fedoraproject.org/~halfie/artifacts/redhat-rpm-config/ URL.

$ sha256sum redhat-rpm-config-9.1.0-56.fc20.*
faad7594b2080fe76497d0ce50808c905a93dd7b41c1defdde5ca57e3833d3d2  redhat-rpm-config-9.1.0-56.fc20.noarch.rpm
5aa9357174305c7285ffdbc92d7ffe1c07a8a95d5459b930461308f5aad75413  redhat-rpm-config-9.1.0-56.fc20.src.rpm
Comment 1 Karel Volný 2013-12-04 11:12:55 UTC 
false positives

(In reply to Dhiru Kholia from comment #0)
> allmenus.cpp:367:69: error: format not a string literal and no format
> arguments [-Werror=format-security]
> allmenus.cpp:370:69: error: format not a string literal and no format
> arguments [-Werror=format-security]

these are constants (defined by make), so it seems like a false positive to me - I've filed bug 1038070 about that

> njamfont.cpp:119:44: error: format not a string literal and no format
> arguments [-Werror=format-security]
> njamfont.cpp:128:44: error: format not a string literal and no format
> arguments [-Werror=format-security]

these arguments are explicitly typed, so, again, I don't see a problem in vodovod code - filed as gcc bug 1038075
Comment 2 Karel Volný 2013-12-04 11:15:38 UTC 
oh, maybe I shouldn't have closed this for tracking purposes ... adding the gcc ones as blocking bugs
Comment 3 Karel Volný 2014-02-03 18:57:26 UTC 
the code changed, I've packaged newer snapshot and did some adjustments ...
http://koji.fedoraproject.org/koji/taskinfo?taskID=6487052
Note You need to log in before you can comment on or make changes to this bug.