Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1045149 (kcm-systemd) - Review Request: kcm-systemd - Systemd control module for KDE
Summary: Review Request: kcm-systemd - Systemd control module for KDE
Keywords:
Status: CLOSED DUPLICATE of bug 1085130
Alias: kcm-systemd
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-19 17:54 UTC by Mario Blättermann
Modified: 2014-04-07 22:39 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-18 19:12:40 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Mario Blättermann 2013-12-19 17:54:09 UTC 
Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/kcm-systemd.spec
SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/kcm-systemd-0.4.0-1.fc19.src.rpm

Description:
Systemd control module for KDE. It provides a graphical frontend for the systemd daemon, which allow for viewing and controlling systemd units, as well as modifying configuration files. It integrates in the System Settings dialogue in KDE.

Fedora Account System Username: mariobl
Comment 1 Mario Blättermann 2013-12-23 21:13:14 UTC 
I've changed the spec to get a downloadable source URL.
Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/kcm-systemd.spec
SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/kcm-systemd-0.4.0-1.fc20.src.rpm

Koji scratch build for f20:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6329350
Comment 2 Kevin Kofler 2013-12-23 23:25:32 UTC 
* Please use BuildRequires: kdelibs4-devel rather than kdelibs-devel.
* Why are you calling the package kcm-systemd and not kcm_systemd with an underscore?
Comment 3 Mario Blättermann 2013-12-25 19:38:38 UTC 
(In reply to Kevin Kofler from comment #2)
> * Please use BuildRequires: kdelibs4-devel rather than kdelibs-devel.
> * Why are you calling the package kcm-systemd and not kcm_systemd with an
> underscore?

The underscore is not allowed in package names:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators
I'm just following the common name scheme for kcm modules, although some of them use the underscore anyway:

$ yum list kcm*
Geladene Plugins: langpacks, refresh-packagekit
Installierte Pakete
kcm-gtk.x86_64                 0.5.3-14.fc20   @fedora                          
kcm-systemd.x86_64             0.4.0-1.fc20    @/kcm-systemd-0.4.0-1.fc20.x86_64
kcm_colors.x86_64              4.11.4-1.fc20   @updates                         
kcm_touchpad.x86_64            0.3.1-10.fc20   @fedora                          
Verfügbare Pakete
kcm-fcitx.x86_64               0.4.3-2.fc20    fedora                           
kcm-qt-graphicssystem.x86_64   1.3-5.fc20      fedora                           
kcm_wacomtablet.x86_64         1.3.7-5.fc20    fedora

New files:
Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/kcm-systemd.spec
SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/kcm-systemd-0.4.0-2.fc20.src.rpm
Comment 4 Kevin Kofler 2013-12-25 21:43:56 UTC 
> packages where the upstream name naturally contains an underscore are excluded
> from this

which IMHO is the case for kcm_* (and IMHO the kcm-* packages are all named incorrectly and should be renamed).
Comment 5 Mario Blättermann 2014-01-18 19:12:40 UTC 
Sorry, I don't want to continue working on this package. I don't use it often enough, and my systemd knowledge is actually poor (although that isn't really required here). The software itself is in an early state of development, so it's currently not worth for me to maintain the package.
Comment 6 Kevin Kofler 2014-04-07 22:39:25 UTC 
So, since this review request was officially withdrawn and I'd really like this package in as a KDE-based and more capable replacement for system-config-services, I filed a new review request. Closing this abandoned review request as a duplicate of the current one.

*** This bug has been marked as a duplicate of bug 1085130 ***
Note You need to log in before you can comment on or make changes to this bug.